[enhance] add request timeout on aixos

[wgx731]

Hi guys,

I have noticed if Vault is not started or down, vault-ui will send request and seems wait forever. Therefore I think we should add request time out for axios module, but as we have two part (express server and react component) both using axios, we may need to find a clean way to do this right. Currently, time is only added to express server part.

NOTE: please check this commit message for TODOs.

Thank you very much.

[msessa]

Hi @wgx731,

I agree we should have a way to control timeouts but your PR seems to be putting most of the logic in the express side of the app.
Vault-UI is by all means a fully client side application, and the nodejs backend part is purely a dumb proxy passthrough.

This means all logic, even request timeouts, should be controlled by the client.

Please take a look at this branch I just pushed for a possible implementation
https://github.com/djenriquez/vault-ui/compare/request_timeout

[wgx731]

@msessa-cotd,

Yes, I agreed. In the first commit, I was trying to put the timeout only in client side, but I am facing problem accessing environment variable in react app. That's why I switched to add the logic in express server part.

If you already have a solution to this enhancement, then I will close this pull request.

Thank you very much.

[msessa]

Thanks for bringing this issue to my attention.

I'll probably push this enhancement shortly after #60 is merged, since that PR removes the custom axios call on login in favour of the unified callVaultApi.