Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Support for custom mountpoint on login #60

Merged
merged 5 commits into from
Mar 1, 2017
Merged

Support for custom mountpoint on login #60

merged 5 commits into from
Mar 1, 2017

Conversation

msessa
Copy link
Collaborator

@msessa msessa commented Feb 23, 2017

In Vault it's possible to mount an authentication backend on a non-standard path (example: userpass backend mounted on auth/employees).

This PR adds support for specifying a custom path in the login settings dialog.

In addition a custom path can be pre-configured by a system administrator with the VAULT_AUTH_BACKEND_PATH environment variable.

@djenriquez
Copy link
Owner

@msessa-cotd

Do you know how often these paths are overridden? The path variable seems like it could be something that would confuse a user who doesn't know that ability exists. Would it make sense for this field to be something that is collapsed by default and only appears if a check box or something is clicked?

@msessa
Copy link
Collaborator Author

msessa commented Feb 23, 2017

You might be right. I could be confusing.

I tend to assume most vault users are power users and pre-configuration using environment variables is the way to bridge the gap.

Anyway, I'll implement your suggestion.

@msessa
Copy link
Collaborator Author

msessa commented Feb 25, 2017

Ok I've nested the textfield in a collapsed Card component.
image

Copy link
Owner

@djenriquez djenriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the card.

@msessa msessa merged commit 984c97b into master Mar 1, 2017
@msessa msessa deleted the login_mountpoint branch March 1, 2017 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants