Supporting setups where Wordpress is not initialized immediately #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled later if Wordpress and the add_filter function are not initialized when package is loaded
djboris88
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the nifty extension!
I ran into an issue trying to use this on a project where WordPress is not immediately initialized. If either add_filter() or WP_DEBUG is not yet defined, the chance to add the the relevant filters is missed and the extension is not used.
Here's a pull request that wraps the initialization code in a function. The extension should still work as before and automatically register if possible. But on projects where that doesn't work out, initialize_filters() can now be called manually in a spot where WordPress initialization can be counted on having happened. I've included a README update to document this.