This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Don't use postconditions on data.http resources
#2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting a `lifecycle.postcondition` on a `data.http` seems to force Terraform to defer reading that resource until the apply phase. This means that any resource that depends in turn on the `data.http` can't be planned, which leaves us unable to deploy new localities. This commit deletes the `lifecycle` blocks, which lets us `plan` and hopefully `apply` again. We should still fail obviously if some JSON manifest can't be fetched, because parsing the JSON or accessing some field of the manifest will fail.
divergentdave
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
I confirmed that passing jsondecode bad data results in Error: Error in function call and a failure of the plan. (However, getting a nonexistent attribute from the resulting object results in null, not an error.) I think the results of all three data objects are covered well enough without the postconditions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a
lifecycle.postconditionon adata.httpseems to force Terraform to defer reading that resource until the apply phase. This means that any resource that depends in turn on thedata.httpcan't be planned, which leaves us unable to deploy new localities.This commit deletes the
lifecycleblocks, which lets usplanand hopefullyapplyagain. We should still fail obviously if some JSON manifest can't be fetched, because parsing the JSON or accessing some field of the manifest will fail.