Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Explicitly check HTTP status of data.http resources #2089

Closed
tgeoghegan opened this issue Oct 7, 2022 · 0 comments
Closed

Explicitly check HTTP status of data.http resources #2089

tgeoghegan opened this issue Oct 7, 2022 · 0 comments

Comments

@tgeoghegan
Copy link
Contributor

In #2088, we deleted some lifecycle.postconditions blocks on data.http resources in Terraform module data_share_processor because they caused problems with planning when adding new localities. Failure to fetch the JSON manifests, or unexpected content, should still cause obvious failures, but ideally we should have explicit checks.

Perhaps this is due to a bug in Terraform that will be fixed, in which case we should put those postconditions declarations back. In the worst case, we can do checks on data.http.<resource>.result.http_code, though Terraform lacks anything like an assert statement.

@divergentdave divergentdave closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants