Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the change from F36 to F38 in the CI base container. #3449

Merged

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Jun 2, 2023

With the change in #3433 from a F36 base to F38, some of the floating point calculations in the Agent legacy post-processing tests are off by "half a bit" relative to their gold files. This PR modifies the gold files to match.

Also, apparently F38 brings an updated tox which processes the Alembic check script invocation differently, so this PR contains a tweak to address that, as well.

PBENCH-1161

…files

These differences are due to the change in the CI container from F36 to F38.

PBENCH-1161
@webbnh webbnh added Agent Code Infrastructure Unit tests fio pbench-fio benchmark related uperf pbench-uperf benchmark related Containerization Of and relating to the process of setting up and maintaining container images Tests labels Jun 2, 2023
@webbnh webbnh added this to the v0.73 milestone Jun 2, 2023
@webbnh webbnh requested review from ndokos and dbutenhof June 2, 2023 22:12
@webbnh webbnh self-assigned this Jun 2, 2023
@webbnh webbnh changed the title Correct half-bit rounding errors in legacy post-processing test gold files Adapt to the change from F36 to F38 in the CI base container. Jun 3, 2023
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the chain of consequences is heavy this weekend ...

@webbnh webbnh merged commit 1f4087f into distributed-system-analysis:main Jun 5, 2023
@webbnh webbnh deleted the half-bit-floating-point-error branch June 5, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Code Infrastructure Containerization Of and relating to the process of setting up and maintaining container images fio pbench-fio benchmark related Tests Unit tests uperf pbench-uperf benchmark related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants