-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI container to Fedora-38 #3433
Update CI container to Fedora-38 #3433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually interesting since I don't think the CI is in any way testing this change, right?
Once I'm satisfied with this change (note that this PR is currently a "draft"), I will use it to build and push an image (which I will sanity check locally), and then I'll make it "live", at which point the CI will start using it for everything...and, if nothing falls over, I'll consider that a successful test. (Think "Ghostbusters" here....) But, you are correct, there is no CI testing of the building of the container image used by the CI (et al.)...which is probably OK, since we don't normally build this image -- we just use it. If we had infinite resources, then, yeah, it would be appropriate to rebuild it at intervals (just to prove that we can), but I don't think it is unreasonable to defer the detection of problems to the point where we actually need to address them. (E.g., we don't need yet another point of failure in our "normal" CI runs.) |
So, the "test" was not successful. (For some reason, on F38, Mr. Jenkins decides to install a new version of So, I'm returning this PR to "draft" status until we can devise a way around this conundrum. |
8258cd9
to
42e27e6
Compare
42e27e6
to
8691537
Compare
This change is now ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Contraints" vs "requirements" ... interesting distinction of which I was previously unaware.
As was I. However, the modern Pip objects if you have more than one requirement for the same package...even if the requirements are compatible! So, I was happy to learn of the support for constraints. (And, once you get into it, separating the constraints from the requirements makes very good sense.) |
Now that Fedora-36 has reached end-of-life, we need to update the default container image used by the CI and
jenkins/run
to F38.However, initial attempts at this proved to be problematic. So, this PR contains two sets of changes:
jenkins/Makefile
to switch the base image for the CI container from F36 to F38; andThe version restriction has basically no effect under F36, so this PR can be merged without adverse affects. Once it has been merged, I'll build and push a new version of the CI container, switching it from the F36 base to the F38 base -- this will break all
main
-branch CI builds which haven't yet been rebased on this PR.PBENCH-1161