Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b0.71 backport: Delete the spurious pbench3-devel RPM dependency #2800

Merged

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented Apr 29, 2022

Fixes #2798

This is a backport of #2799 to b0.71.

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

@ndokos ndokos added bug Agent packaging Issues related to software packaging labels Apr 29, 2022
@ndokos ndokos added this to the v0.71 milestone Apr 29, 2022
@ndokos ndokos self-assigned this Apr 29, 2022
dbutenhof
dbutenhof previously approved these changes Apr 29, 2022
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also verify that gcc is required.

webbnh
webbnh previously approved these changes Apr 29, 2022
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Let's also verify that gcc is required.

Oh, I am so sorry, @ndokos! 🥴

Fixes distributed-system-analysis#2798

This is a backport of distributed-system-analysis#2799 to b0.71.

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

Clean up the unnecessary gcc dependency as well.
@ndokos ndokos dismissed stale reviews from webbnh and dbutenhof via 8c96126 April 29, 2022 20:41
@ndokos ndokos force-pushed the python3-devel-b0.71 branch from c2b3f67 to 8c96126 Compare April 29, 2022 20:41
@ndokos ndokos requested review from portante, dbutenhof and webbnh April 29, 2022 20:44
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@portante portante merged commit 2035ccf into distributed-system-analysis:b0.71 Apr 30, 2022
@ndokos ndokos deleted the python3-devel-b0.71 branch April 30, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent bug packaging Issues related to software packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants