Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the spurious pbench3-devel RPM dependency #2799

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented Apr 28, 2022

Fixes #2798

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

@ndokos ndokos added bug Agent packaging Issues related to software packaging labels Apr 28, 2022
@ndokos ndokos added this to the v0.71 milestone Apr 28, 2022
@ndokos ndokos self-assigned this Apr 28, 2022
webbnh
webbnh previously approved these changes Apr 28, 2022
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need gcc? 😁

Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should double check, but I don't think we need gcc as a result of removing this dependency.

ndokos added a commit to ndokos/pbench that referenced this pull request Apr 29, 2022
Fixes distributed-system-analysis#2798

This is a backport of distributed-system-analysis#2799 to b0.71.

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.
dbutenhof
dbutenhof previously approved these changes Apr 29, 2022
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...

@portante portante modified the milestones: v0.71, v0.72 Apr 29, 2022
Fixes distributed-system-analysis#2798

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

Clean up the unnecessary gcc dependency as well.
@ndokos ndokos dismissed stale reviews from dbutenhof and webbnh via 5008b3b April 29, 2022 20:20
@ndokos ndokos requested review from portante, dbutenhof and webbnh April 29, 2022 20:32
ndokos added a commit to ndokos/pbench that referenced this pull request Apr 29, 2022
Fixes distributed-system-analysis#2798

This is a backport of distributed-system-analysis#2799 to b0.71.

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

Clean up the unnecessary gcc dependency as well.
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ndokos ndokos merged commit 82b3ca6 into distributed-system-analysis:main Apr 30, 2022
@ndokos ndokos deleted the python3-devel branch April 30, 2022 01:56
portante pushed a commit that referenced this pull request Apr 30, 2022
Fixes #2798

This is a backport of #2799 to b0.71.

AFAICT, the python3-devel dependency (which only exists for RHEL7) is
spurious and in fact harmful: there seems to be no python3-devel
package for RHEL7.9, so installation fails with an unsatisfied
dependency, whereas an RPM built without it installs without
problems.

Clean up the unnecessary gcc dependency as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent bug Installation packaging Issues related to software packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Installation of pbench-agent RPM fails on RHEL7.9 because of unsatisfied dependency
4 participants