Generalized contract_info TLV #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
suggested changes
Jan 27, 2021
Messaging.md
Outdated
| * [`bool`:`maximize_coverage`] | ||
|
|
||
| This type is used when there is a shared error bounds requirement for any set of oracles in a | ||
| multi-oracle numeric outcome DLC with allowed (bounded) error. |
There was a problem hiding this comment.
This is probably waiting on #128 but should add a link to explain what this is / how it is used
Tibo-lg
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Looks good, feel free too ignore my suggestions but I where I put them is in general because I feel the sentences are difficult to get if you don't already have a good understanding of how things are supposed to work (which is maybe fine, but it might also not hurt to make things a bit more intelligible IMHO).
nkohen
force-pushed
the
general-contract-info
branch
from
a8876ed to
2fda0dd
Compare
Tibo-lg
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated TLVs to allow support for numeric outcome and multiple oracle DLCs.