Use oracle_announcement in place of distinct oracle_info #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
benthecarman
suggested changes
Oct 14, 2020
| This type of contract info is a simple enumeration where the value `n` is omitted from being | ||
| explicitly included as it can be derived from the length field of the TLV and should already be | ||
| known from the corresponding `oracle_announcement`. | ||
| The order of payouts matches the order of the outcomes in the `oracle_announcement`. |
There was a problem hiding this comment.
The oracle_announcement doesn't have the outcomes, it is actually oracle_announcement -> oracle_event -> event_descriptor
There was a problem hiding this comment.
Maybe should exclude multi nonce descriptors here because I would have no idea what the ordering would be here
There was a problem hiding this comment.
not sure what you mean? If you find an enum_contract_info you better have gotten an enum_event_descriptor
|
Replaced by #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.