Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildMember): make GuildMember#setNickname first param nullable #5070

Merged
merged 5 commits into from
Dec 12, 2020
Merged

feat(GuildMember): make GuildMember#setNickname first param nullable #5070

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bf521d
Update index.d.ts
zaida04 Dec 1, 2020
d8b78cb
Update GuildMember.js
zaida04 Dec 1, 2020
105238f
Update src/structures/GuildMember.js
zaida04 Dec 1, 2020
4f96380
Update GuildMember.js
zaida04 Dec 10, 2020
4fba8fb
Update index.d.ts
zaida04 Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/structures/GuildMember.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ class GuildMember extends Base {

/**
* Sets the nickname for this member.
* @param {string} nick The nickname for the guild member
* @param {string|null} nick The nickname for the guild member, or `null` if you want to reset their nickname
zaida04 marked this conversation as resolved.
Show resolved Hide resolved
* @param {string} [reason] Reason for setting the nickname
* @returns {Promise<GuildMember>}
*/
Expand Down
2 changes: 1 addition & 1 deletion typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ declare module 'discord.js' {
): boolean;
public kick(reason?: string): Promise<GuildMember>;
public permissionsIn(channel: ChannelResolvable): Readonly<Permissions>;
public setNickname(nickname: string, reason?: string): Promise<GuildMember>;
public setNickname(nickname: string | null, reason?: string): Promise<GuildMember>;
public toJSON(): object;
public toString(): string;
public valueOf(): string;
Expand Down