Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildMember): make GuildMember#setNickname first param nullable #5070

Merged
merged 5 commits into from
Dec 12, 2020

Conversation

zaida04
Copy link
Contributor

@zaida04 zaida04 commented Dec 1, 2020

Passing null into GuildMember#setNickname will reset the nickname. But neither the typings nor the jsdoc indicate that you can pass that in.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@zaida04
Copy link
Contributor Author

zaida04 commented Dec 1, 2020

In response to #5068

@kyranet kyranet requested a review from SpaceEEC December 8, 2020 21:24
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also need to be documented here:

* @property {string} [nick] The nickname to set for the member

And here:
nick?: string;

@iCrawl iCrawl merged commit d70127c into discordjs:master Dec 12, 2020
@zaida04 zaida04 deleted the patch-2 branch February 2, 2021 15:17
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants