-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GuildMember): make GuildMember#setNickname first param nullable #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to #5068 |
vaporoxx
reviewed
Dec 1, 2020
Co-authored-by: Jan <[email protected]>
iCrawl
approved these changes
Dec 8, 2020
5 tasks
kyranet
approved these changes
Dec 8, 2020
vladfrangu
approved these changes
Dec 8, 2020
SpaceEEC
requested changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also need to be documented here:
discord.js/src/structures/GuildMember.js
Line 277 in 105238f
* @property {string} [nick] The nickname to set for the member |
And here:
Line 2651 in 105238f
nick?: string; |
SpaceEEC
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing null into GuildMember#setNickname will reset the nickname. But neither the typings nor the jsdoc indicate that you can pass that in.
Status
Semantic versioning classification: