feat(builders): update to @sapphire/shapeshift v4 #10291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10291 +/- ##
==========================================
+ Coverage 50.77% 50.88% +0.11%
==========================================
Files 228 228
Lines 20711 20761 +50
Branches 1258 1258
==========================================
+ Hits 10515 10565 +50
Misses 10152 10152
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
favna
force-pushed
the
refactor/update-to-shapeshift-v4
branch
from
5dc221c
to
52c8b74
Compare
vladfrangu
approved these changes
Jul 28, 2024
favna
force-pushed
the
refactor/update-to-shapeshift-v4
branch
from
52c8b74
to
c928a7a
Compare
iCrawl
approved these changes
Aug 19, 2024
kyranet
approved these changes
Aug 19, 2024
favna
force-pushed
the
refactor/update-to-shapeshift-v4
branch
from
c928a7a
to
2d62870
Compare
imnaiyar
pushed a commit
to imnaiyar/discord.js
that referenced
this pull request
Aug 20, 2024
feat: update to @sapphire/shapeshift v4
kodiakhq bot
added a commit
that referenced
this pull request
Aug 20, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <[email protected]> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> * feat(Attachment): add `title` (#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Danial Raza <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jeroen Claassens <[email protected]> Co-authored-by: DD <[email protected]>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
feat: update to @sapphire/shapeshift v4
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (discordjs#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <[email protected]> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> * feat(Attachment): add `title` (discordjs#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (discordjs#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (discordjs#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Danial Raza <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jeroen Claassens <[email protected]> Co-authored-by: DD <[email protected]>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
feat: update to @sapphire/shapeshift v4
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (discordjs#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <[email protected]> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> * feat(Attachment): add `title` (discordjs#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (discordjs#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (discordjs#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Danial Raza <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jeroen Claassens <[email protected]> Co-authored-by: DD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This updates the Shapeshift dependency and related code to @sapphire/shapeshift v4. This does not yet add custom messages to all the functions, which needs further discussion on what to set where. In a way this PR can also be a jumping-off point for @Qjuh. This PR also has a relation to #10117.
While this concerns a new major version of Shapeshift, there are no user-facing breaking changes to @discordjs/builders in this version that would incur the need for a new major version of @discordjs/builders.
Status and versioning classification: