Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builders): update to @sapphire/shapeshift v4 #10291

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

favna
Copy link
Contributor

@favna favna commented May 20, 2024

Please describe the changes this PR makes and why it should be merged:

This updates the Shapeshift dependency and related code to @sapphire/shapeshift v4. This does not yet add custom messages to all the functions, which needs further discussion on what to set where. In a way this PR can also be a jumping-off point for @Qjuh. This PR also has a relation to #10117.

While this concerns a new major version of Shapeshift, there are no user-facing breaking changes to @discordjs/builders in this version that would incur the need for a new major version of @discordjs/builders.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@favna favna requested review from a team and iCrawl as code owners May 20, 2024 16:02
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 6:09pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 6:09pm

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.88%. Comparing base (bbef68d) to head (2d62870).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10291      +/-   ##
==========================================
+ Coverage   50.77%   50.88%   +0.11%     
==========================================
  Files         228      228              
  Lines       20711    20761      +50     
  Branches     1258     1258              
==========================================
+ Hits        10515    10565      +50     
  Misses      10152    10152              
  Partials       44       44              
Flag Coverage Δ
builders 95.84% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favna favna force-pushed the refactor/update-to-shapeshift-v4 branch from 52c8b74 to c928a7a Compare July 28, 2024 13:49
@favna favna force-pushed the refactor/update-to-shapeshift-v4 branch from c928a7a to 2d62870 Compare August 19, 2024 18:08
@kodiakhq kodiakhq bot merged commit 2d5531f into discordjs:main Aug 19, 2024
24 checks passed
@TAEMBO TAEMBO mentioned this pull request Aug 20, 2024
imnaiyar pushed a commit to imnaiyar/discord.js that referenced this pull request Aug 20, 2024
kodiakhq bot added a commit that referenced this pull request Aug 20, 2024
* build: bump discord-api-types to 0.37.95

* feat: Add support for Automated Message nonce handling (#10381)

* Add support for Automated Message nonce handling

* Fix options property

* Address PR feedback

* Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback

* Fix lint issue

* Fix lint issue

* Move to MessagePayload.resolveBody instead

* Fix test errors

* Update packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <[email protected]>

* PR feedback

* Merge

* Let and not const

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>

* feat(Attachment): add `title` (#10423)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* types: Fix wrong auto moderation target type (#10391)

types: fix wrong auto moderation target type

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(builders): update to @sapphire/shapeshift v4 (#10291)

feat: update to @sapphire/shapeshift v4

* refactor(actions): safer getChannel calls (#10434)

* refactor(actions): safer getChannel calls

* chore: consistency

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* build: bump discord-api-types tp 0.37.96

---------

Co-authored-by: Jacob Morrison <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Danial Raza <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jeroen Claassens <[email protected]>
Co-authored-by: DD <[email protected]>
@favna favna deleted the refactor/update-to-shapeshift-v4 branch August 24, 2024 18:06
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
* build: bump discord-api-types to 0.37.95

* feat: Add support for Automated Message nonce handling (discordjs#10381)

* Add support for Automated Message nonce handling

* Fix options property

* Address PR feedback

* Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback

* Fix lint issue

* Fix lint issue

* Move to MessagePayload.resolveBody instead

* Fix test errors

* Update packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <[email protected]>

* PR feedback

* Merge

* Let and not const

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>

* feat(Attachment): add `title` (discordjs#10423)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* types: Fix wrong auto moderation target type (discordjs#10391)

types: fix wrong auto moderation target type

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291)

feat: update to @sapphire/shapeshift v4

* refactor(actions): safer getChannel calls (discordjs#10434)

* refactor(actions): safer getChannel calls

* chore: consistency

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* build: bump discord-api-types tp 0.37.96

---------

Co-authored-by: Jacob Morrison <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Danial Raza <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jeroen Claassens <[email protected]>
Co-authored-by: DD <[email protected]>
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* build: bump discord-api-types to 0.37.95

* feat: Add support for Automated Message nonce handling (discordjs#10381)

* Add support for Automated Message nonce handling

* Fix options property

* Address PR feedback

* Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback

* Fix lint issue

* Fix lint issue

* Move to MessagePayload.resolveBody instead

* Fix test errors

* Update packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <[email protected]>

* PR feedback

* Merge

* Let and not const

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>

* feat(Attachment): add `title` (discordjs#10423)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* types: Fix wrong auto moderation target type (discordjs#10391)

types: fix wrong auto moderation target type

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291)

feat: update to @sapphire/shapeshift v4

* refactor(actions): safer getChannel calls (discordjs#10434)

* refactor(actions): safer getChannel calls

* chore: consistency

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* build: bump discord-api-types tp 0.37.96

---------

Co-authored-by: Jacob Morrison <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Danial Raza <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jeroen Claassens <[email protected]>
Co-authored-by: DD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants