Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Automated Message nonce handling #10381

Merged
merged 20 commits into from
Aug 19, 2024
Merged

Conversation

JMTK
Copy link
Contributor

@JMTK JMTK commented Jul 9, 2024

Please describe the changes this PR makes and why it should be merged:
Took a stab at doing this, let me know if there's any issues! Fixes #10323

Only thing I thought about was to instead make this a function you can pass in to generate nonces, so something like

if (typeof this.client.options.generateNonce === 'function') {
    options.nonce = this.client.options.generateNonce();
}

But the users may run into issues, such as the 25 character limit, generating high collision nonces, etc

Status and versioning classification:
Minor

@JMTK JMTK requested a review from a team as a code owner July 9, 2024 19:34
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 2:02pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 2:02pm

@JMTK JMTK changed the title Add support for Automated Message nonce handling [feat] Add support for Automated Message nonce handling Jul 9, 2024
@JMTK JMTK changed the title [feat] Add support for Automated Message nonce handling feat: Add support for Automated Message nonce handling Jul 9, 2024
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we handle when enforceNonce: false is explicitly passed?

const createdMessage = await message.channel.send({
	content: "hello",
	enforceNonce: false,
});

// `createdMessage` has a nonce which is enforced despite `enforceNonce` being `false`.

@JMTK JMTK requested a review from Jiralite July 11, 2024 18:43
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* Add support for Automated Message nonce handling

* Fix options property

* Address PR feedback

* Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback

* Fix lint issue

* Fix lint issue

* Move to MessagePayload.resolveBody instead

* Fix test errors

* Update packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <[email protected]>

* PR feedback

* Merge

* Let and not const

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* build: bump discord-api-types to 0.37.95

* feat: Add support for Automated Message nonce handling (discordjs#10381)

* Add support for Automated Message nonce handling

* Fix options property

* Address PR feedback

* Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback

* Fix lint issue

* Fix lint issue

* Move to MessagePayload.resolveBody instead

* Fix test errors

* Update packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <[email protected]>

* PR feedback

* Merge

* Let and not const

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>

* feat(Attachment): add `title` (discordjs#10423)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* types: Fix wrong auto moderation target type (discordjs#10391)

types: fix wrong auto moderation target type

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291)

feat: update to @sapphire/shapeshift v4

* refactor(actions): safer getChannel calls (discordjs#10434)

* refactor(actions): safer getChannel calls

* chore: consistency

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* build: bump discord-api-types tp 0.37.96

---------

Co-authored-by: Jacob Morrison <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Danial Raza <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jeroen Claassens <[email protected]>
Co-authored-by: DD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automated Message nonce handling
7 participants