openExternalLink returns a { opened: boolean | null } result
#7273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaAtDiscord
requested review from
JustinBeckwith
and removed request for
a team
jkap
approved these changes
Nov 15, 2024
afgiel
approved these changes
Nov 18, 2024
matthova
approved these changes
Nov 19, 2024
HamzaAtDiscord
changed the title
openExternalLink returns a { opened: boolean } resultopenExternalLink returns a { opened: boolean | null } result
shaydewael
approved these changes
Nov 19, 2024
| @@ -1335,6 +1335,14 @@ No scopes required | |||
| |----------|--------| | |||
| | url | string | | |||
|
|
|||
| #### OpenExternalLinkResponse | |||
|
|
|||
| > **Note:** `{ opened: null }` is returned on older Discord clients that do not report the result of the open link action. | |||
There was a problem hiding this comment.
Suggested change
| > **Note:** `{ opened: null }` is returned on older Discord clients that do not report the result of the open link action. | |
| > warn | |
| > `{ opened: null }` is returned on older Discord clients that do not report the result of the open link action. |
There was a problem hiding this comment.
is there an "earliest client" we can include that would have this, or just include an approximate date (clients from before November XX, 2024)? just so when this is present, it still makes sense in a month or two
There was a problem hiding this comment.
Updated with the warn and to include a rough date (dec 24)
HamzaAtDiscord
deleted the
hamzahutchinson/change-open-external-link-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the return type for
openExternalLink. With this change the result ofopenExternalLinkwill be an object containing a boolean valueopened.If
openedis true, then the link was opened by the userIf
openedis false, then the link was not opened by the userThe lifetime of the promise is also changed. Previously the promise completed after opening the "Leaving Discord" dialog, but with this change the promise completes after the user selects an action in the dialog (visit the site, or go back). If the dialog does not appear because the site visit is automatically approved, then the promise returns
{ opened: true }following the link opening.