Skip to content

Commit

Permalink
openExternalLink returns a { opened: boolean | null } result (#7273)
Browse files Browse the repository at this point in the history
* Add a response type for openExternalLink that returns a boolean opened value

* updating the documentation to include the null case for older discord clients

* doc update
  • Loading branch information
HamzaAtDiscord authored Nov 21, 2024
1 parent 19ea995 commit a9fced6
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion docs/developer_tools/Embedded_App_SDK.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ No scopes required
#### Signature

<Monospace>
openExternalLink(args: [OpenExternalLinkRequest](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkrequest)): Promise\<void\>
openExternalLink(args: [OpenExternalLinkRequest](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkrequest)): Promise\<[OpenExternalLinkResponse](#DOCS_DEVELOPER_TOOLS_EMBEDDED_APP_SDK/openexternallinkresponse)\>
</Monospace>

#### Usage
Expand Down Expand Up @@ -1335,6 +1335,15 @@ No scopes required
|----------|--------|
| url | string |

#### OpenExternalLinkResponse

> warn
> `{ opened: null }` is returned on Discord clients before December 2024 that do not report the open link result.
| Property | Type |
|----------|-----------------|
| opened | boolean \| null |

#### OpenInviteDialogRequest

| Property | Type |
Expand Down

0 comments on commit a9fced6

Please sign in to comment.