Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the ResultsList data structure with the Results #563

Merged
merged 14 commits into from
May 6, 2024

Conversation

jeremykubica
Copy link
Contributor

This is the second half of the change to switch from ResultsList to Results. The main part of this change is replacing ResultList in run_search.py andtrajectory_explorer.py.

At the same time, using Results simplified the logic throughout the code base and lets us remove some now unneeded code, including:

  • ResultList and ResultRow (all of result_list.py)
  • The per-row filters including the base class, stats filters (now handled by masking), and stamp filters (never used as a row-filter)
  • A bunch of individual results files used for testing and demos that are no longer needed.

The PR also updates the tests and notebooks (which is where the bulk of the diffs come from).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jeremykubica jeremykubica mentioned this pull request Apr 23, 2024
Copy link
Member

@DinoBektesevic DinoBektesevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The satisfaction scrolling through all these deleted files and locs...

@jeremykubica jeremykubica merged commit 52fba97 into main May 6, 2024
2 checks passed
@jeremykubica jeremykubica deleted the result_table2 branch May 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants