Some parts of lib in no_std with alloc. Tests pass #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only. Main change was with alloc crate introduction. Some messiness still persists. WIP
…in alloc. Parry2d and parry3d compiles in alloc. Tests still don't.
… as much as I can go without doing anything weird
…y3d requires no_std spade dependency
… no real prod use and many features are gated unnecessarily, but its a good start IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready, but not complete work, some things are still gated. I just tried to make it compile first, then for tests to pass. As it happened, here's the PR. I still have not used it in real product, and I did it blindly, so its a draft for now, though I don't expect much more work to be done here. Please verify carefully. Testing/review appreciated.
I have no idea how to split this, organize etc. Any opinions, refactor ideas appreciated. I tried to not change as much code as possible, sometimes it doesn't make any sense, sometimes looks stupid. But essentially all commits should compile in some way using
no_stdandallocfeatures.PR requires this: Stoeoef/spade#92, so you can see this dependency in Cargo.toml for now. If it will be merged, I'll change dependency here.
As I wrote in the beginning I would like for this to not be full "no_std+alloc". Some parts are still gated. Its just a good start I hope, and if it gets merged I hope the rest may be done quickly. But I can of course add more if someone advise so. My main fear is that I just don't know if any of this actually works, so I would prefer to scope low.