905: Send automatic mail for new applications and verifications #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsporck
force-pushed
the
905-application-send-automatic-mail-for-new-applications
branch
4 times, most recently
from
88a029c to
a6055b1
Compare
f1sh1918
approved these changes
May 8, 2023
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
| val message = """ | ||
| Guten Tag, | ||
|
|
||
| Ein ein Antrag ist Verifiziert worden. |
There was a problem hiding this comment.
Suggested change
| Ein ein Antrag ist Verifiziert worden. | |
| ein neuer Antrag wurde verifiziert. |
|
|
||
| Falls Sie keine weiteren Benachrichtigungen zu neuen Anträgen erhalten möchten können Sie dies unter ${projectConfig.administrationBaseUrl}/user-settings deaktivieren. | ||
|
|
||
| Dies ist eine automatisierte Nachricht. Antworten Sie nicht auf diese Email. |
There was a problem hiding this comment.
Suggested change
| Dies ist eine automatisierte Nachricht. Antworten Sie nicht auf diese Email. | |
| Dies ist eine automatisierte Nachricht. Bitte antworten Sie nicht auf diese Email. |
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/user-settings/NotificationSettings.tsx
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt
Outdated
Show resolved
Hide resolved
sarahsporck
force-pushed
the
905-application-send-automatic-mail-for-new-applications
branch
from
3146a1a to
2e0542d
Compare
sarahsporck
deleted the
905-application-send-automatic-mail-for-new-applications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to rename useQueryHandler as it is in fact not a hook (Kinda messed this up in the other pr) and therefore eslint would not allow to use it in other hooks. Renaming fixed this.
Additionally I moved the mails that are sent into the mailer (but I did not change the messages, so no need to review this :)). This way we have a much better overview of what default sentences and structure we use in the mails.
Due to the rename there were still quite a few files changed. Sorry for this 🙈