654: remove verification feature flag and add camera permission #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
approved these changes
Dec 5, 2022
maxammann
approved these changes
Dec 5, 2022
f1sh1918
reviewed
Dec 6, 2022
| @@ -42,4 +42,7 @@ | |||
| <!--<uses-permission android:name="android.permission.CAMERA" tools:node="remove"/>--> | |||
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove"/> | |||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove"/> | |||
|
|
|||
There was a problem hiding this comment.
is here a whitespace needed?
There was a problem hiding this comment.
I think it contributes to a better readability as there is already a space between Location Permission and External Storage Permission
sarahsporck
force-pushed
the
654-re-enable-camera-permission
branch
from
f581559 to
d9bea88
Compare
sarahsporck
force-pushed
the
654-re-enable-camera-permission
branch
2 times, most recently
from
47b3a9c to
45365e9
Compare
sarahsporck
force-pushed
the
654-re-enable-camera-permission
branch
from
45365e9 to
dbf7c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.