654: remove verification feature flag and add camera permission

digitalfabrik · Dec 5, 2022 · f581559 · f581559
1 parent 33d7c5d
commit f581559
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 25 deletions.
diff --git a/frontend/android/app/src/main/AndroidManifest.xml b/frontend/android/app/src/main/AndroidManifest.xml
@@ -42,4 +42,7 @@
     <!--<uses-permission android:name="android.permission.CAMERA" tools:node="remove"/>-->
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove"/>
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove"/>
+
+    <uses-feature android:name="android.hardware.camera" android:required="false" />
+    <uses-permission android:name="android.permission.CAMERA" />
 </manifest>
diff --git a/frontend/build-configs/bayern/index.ts b/frontend/build-configs/bayern/index.ts
@@ -23,9 +23,7 @@ export const bayernCommon: CommonBuildConfigType = {
         showcase: "https://api.entitlementcard.app",
         local: "http://localhost:8000",
     },
-    featureFlags: {
-        verification: true,
-    },
+    featureFlags: {},
     applicationUrl: "https://bayern.ehrenamtskarte.app/apply-for-eak",
 };
 

diff --git a/frontend/build-configs/nuernberg/index.ts b/frontend/build-configs/nuernberg/index.ts
@@ -23,9 +23,7 @@ export const nuernbergCommon: CommonBuildConfigType = {
         showcase: "https://api.entitlementcard.app",
         local: "http://localhost:7000",
     },
-    featureFlags: {
-        verification: true,
-    },
+    featureFlags: {},
     applicationUrl: "https://meinkonto.nuernberg.de/intelliform/forms/osg/standard/osg/osg-kette-starten/index?lebenslageIdAuswahl=w_500_sha_d_nuernberg-pass",
 };
 

diff --git a/frontend/build-configs/types.ts b/frontend/build-configs/types.ts
@@ -4,9 +4,7 @@ type BuildConfigType = {
     ios: iOSBuildConfigType,
 }
 
-export type FeatureFlagsType = {
-    verification: boolean
-}
+export type FeatureFlagsType = {}
 
 export type ThemeType = {
     primaryColor: string,

diff --git a/frontend/lib/configuration/configuration.dart b/frontend/lib/configuration/configuration.dart
@@ -4,15 +4,13 @@ class Configuration extends InheritedWidget {
   final String mapStyleUrl;
   final String graphqlUrl;
   final String projectId;
-  final bool showVerification;
   final bool showDevSettings;
 
   const Configuration({
     super.key,
     required this.mapStyleUrl,
     required this.graphqlUrl,
     required this.projectId,
-    required this.showVerification,
     required this.showDevSettings,
     required super.child,
   });
@@ -22,7 +20,6 @@ class Configuration extends InheritedWidget {
       mapStyleUrl != oldWidget.mapStyleUrl ||
       graphqlUrl != oldWidget.graphqlUrl ||
       projectId != oldWidget.projectId ||
-      showVerification != oldWidget.showVerification ||
       showDevSettings != oldWidget.showDevSettings;
 
   static Configuration of(BuildContext context) {

diff --git a/frontend/lib/entry_widget.dart b/frontend/lib/entry_widget.dart
@@ -31,9 +31,7 @@ class EntryWidget extends StatelessWidget {
             introRouteName: (context) => IntroScreen(
                   onFinishedCallback: () => settings.setFirstStart(enabled: false),
                 ),
-            homeRouteName: (context) => HomePage(
-                  showVerification: configuration.showVerification,
-                )
+            homeRouteName: (context) => const HomePage()
           };
 
           final String initialRoute = settings.firstStart ? introRouteName : homeRouteName;

diff --git a/frontend/lib/home/home_page.dart b/frontend/lib/home/home_page.dart
@@ -10,9 +10,8 @@ import 'package:flutter/material.dart';
 const mapTabIndex = 0;
 
 class HomePage extends StatefulWidget {
-  final bool showVerification;
 
-  const HomePage({super.key, required this.showVerification});
+  const HomePage({super.key});
 
   @override
   _HomePageState createState() => _HomePageState();
@@ -44,13 +43,12 @@ class _HomePageState extends State<HomePage> {
         "Suche",
         GlobalKey<NavigatorState>(debugLabel: "Search tab key"),
       ),
-      if (widget.showVerification)
-        AppFlow(
-          const IdentificationPage(title: "Ausweisen"),
-          Icons.remove_red_eye_outlined,
-          "Ausweisen",
-          GlobalKey<NavigatorState>(debugLabel: "Auth tab key"),
-        ),
+      AppFlow(
+        const IdentificationPage(title: "Ausweisen"),
+        Icons.remove_red_eye_outlined,
+        "Ausweisen",
+        GlobalKey<NavigatorState>(debugLabel: "Auth tab key"),
+      ),
       AppFlow(const AboutPage(), Icons.info_outline, "Über", GlobalKey<NavigatorState>(debugLabel: "About tab key")),
     ];
   }

diff --git a/frontend/lib/main.dart b/frontend/lib/main.dart
@@ -33,7 +33,6 @@ Future<void> main() async {
       mapStyleUrl: mapStyleUrl,
       graphqlUrl: graphqlUrl,
       projectId: projectId,
-      showVerification: buildConfig.featureFlags.verification,
       showDevSettings: kDebugMode,
       child: const App(),
     ),