Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1177: Translate build configs #1189

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

steffenkleinle
Copy link
Member

Short description

Move the localizations from the build config to the l10n json files. Add overwrites for Nürnberg. Translate them.

Proposed changes

  • Move localizations from build config (intro + identification) to the corresponding l10n json files
  • Enable overwrites for Nürnberg
  • Translate the new constants

Side effects

None.

Resolved issues

Fixes: #1177.

@steffenkleinle steffenkleinle changed the base branch from main to 1177-slang October 26, 2023 13:32
Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android. Works nice! Translations sometimes read a little bit wonky, e.g. "Plays" in the categories or what is "Digital Participation" In the context of locations. But I'm also not really proficient enough to correct you here ^.^

frontend/assets/l10n/main/app_en.json Outdated Show resolved Hide resolved
frontend/assets/l10n/nuernberg/overwrite_en.json Outdated Show resolved Hide resolved
@steffenkleinle
Copy link
Member Author

Tested on Android. Works nice! Translations sometimes read a little bit wonky, e.g. "Plays" in the categories or what is "Digital Participation" In the context of locations. But I'm also not really proficient enough to correct you here ^.^

Changed "Plays" to "Shows", still not really happy with it though. "Digital participation" is just the translation of "Digitale Teilhabe" where we have the same issue. However, it is also a category so I think that one is okay. If you have any other things you are unhappy about let me know and I'll try to find an alternative.

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works fine :)

Base automatically changed from 1177-slang to 1178-english-constants November 6, 2023 13:41
@steffenkleinle steffenkleinle merged commit 87e0f31 into 1178-english-constants Nov 6, 2023
1 check passed
@steffenkleinle steffenkleinle deleted the 1177-translate-build-configs branch November 6, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sozialpass] Translate the build configs
4 participants