more determinism in delete order (forward port of #16401) #16471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
added
component/json-api
S11001001
changed the title
S11001001
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Included suggestions as commits on the branch; @BryceStansfieldAt-da please take a look and merge if you have no followups to those.
@ray-roestenburg-da could you take a second look, as the determinism logic has necessarily changed for interface support, please?
Comment on lines
8
to
15
| import nonempty.{NonEmpty, +-:} | ||
| import nonempty.{+-:, NonEmpty} | ||
| import nonempty.NonEmptyReturningOps._ | ||
|
|
||
| import doobie._ | ||
| import doobie.implicits._ | ||
|
|
||
| import scala.annotation.nowarn | ||
| import scala.collection.immutable.{Seq => ISeq, SortedMap} | ||
| import scalaz.{@@, Cord, Functor, OneAnd, Tag, \/, -\/, \/-} | ||
| import scala.collection.immutable.{SortedMap, Seq => ISeq} | ||
| import scalaz.{-\/, @@, Cord, Functor, OneAnd, Tag, \/, \/-} |
| templateId, | ||
| ) | ||
| ) | ||
| .via(conflation) |
There was a problem hiding this comment.
Comment on lines
343
to
344
| Update[String](s"DELETE FROM $contractTableNameRaw WHERE contract_id = ?") | ||
| .updateMany(cids.values.flatten.toSeq.sorted) |
9 tasks
ray-roestenburg-da
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #16401 and #16448 from 2.3.x to main.