more determinism in delete order #16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a prerequisite to make order-by on delete meaningful for large transactions
stephencompall-DA
assigned stephencompall-DA, S11001001 and BryceStansfieldAt-da and unassigned stephencompall-DA
CHANGELOG_BEGIN - [JSON API] Update the database in a different way that should lead to more predictable behavior with higher-performance transaction conflicts on Oracle. CHANGELOG_END
- suggested by @ray-roestenburg-da; thanks
…t up to ledger end
…x+delete-order-by
S11001001
reviewed
Mar 2, 2023
| @@ -882,6 +900,8 @@ private final class OracleQueries( | |||
| protected[this] override def toDBContractKey[CK: JsonWriter](x: CK): DBContractKey = | |||
| JsObject(Map("key" -> x.toJson)) | |||
|
|
|||
| override def allowDamlTransactionBatching = true | |||
BryceStansfieldAt-da
added a commit
that referenced
this pull request
Mar 7, 2023
S11001001
added a commit
that referenced
this pull request
Mar 8, 2023
* Forward port of #16401 * specify arguments for delete in a fixed order * disable backpressure transaction batching for Oracle update * deterministic specification of offset update DMLs * switch to updateMany for delete instead of `in` on Oracle - suggested by @ray-roestenburg-da; thanks * don't update ledger_offset table or start transaction stream if caught up to ledger end * include tpid in delete order consideration --------- Co-authored-by: Stephen Compall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infor delete entirely on Oracle#16261 should also be merged.