declare retroactive interface implementations in TypeScript #14892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
added
component/js-ecosystem
CHANGELOG_BEGIN - [TypeScript codegen] Support for retroactive interface implementations included. Choice inheritance is deprecated and `will be removed <https://github.com/digital-asset/daml/issues/14893>`__; to invoke an interface choice on a template-typed contract ID, convert it to an interface-typed ID with *TemplateName*``.toInterface``. CHANGELOG_END
S11001001
requested review from
garyverhaegen-da and
ray-roestenburg-da
as code owners
ray-roestenburg-da
approved these changes
Aug 31, 2022
ray-roestenburg-da
approved these changes
Sep 2, 2022
cocreature
reviewed
Sep 2, 2022
| @@ -639,69 +639,87 @@ describe("interface definition", () => { | |||
| expect(c).not.toEqual(theChoice(if2[k])); | |||
| expect(c.template()).toBe(tpl); | |||
| }); | |||
|
|
|||
| test("retroactive interfaces permit contract ID conversion", () => { | |||
There was a problem hiding this comment.
any reason we're not testing exercises somewhere?
There was a problem hiding this comment.
The tests further down test interface exercise; there is absolutely no difference for retros from the perspective of codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14082.