Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve retroactive interfaces in js codegen #14082

Closed
1 task done
S11001001 opened this issue Jun 2, 2022 · 0 comments · Fixed by #14892
Closed
1 task done

resolve retroactive interfaces in js codegen #14082

S11001001 opened this issue Jun 2, 2022 · 0 comments · Fixed by #14892
Assignees
@S11001001
Labels
component/js-ecosystem TypeScript and React.js bindings roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

S11001001 commented Jun 2, 2022 •
edited
Loading

As @cocreature mentioned in this discussion #14134 (comment), the way we load modules, the below could yield circular loading; example and possible solution there. The big unknown is typing the contract ID conversion function to properly make use of the template companion and interface companion.

In TsCodeGenMain, genModule can make an index of template IDs to "extra" tplImplements', to be narrowed and passed down to genDefDataType. This can be derived from pkgMap; possibly it should be incorporated in Daml2jsParams and passed in, so it only needs to be computed once.
@S11001001 S11001001 added component/js-ecosystem TypeScript and React.js bindings team/ledger-clients Related to the Ledger Clients team's components. labels Jun 2, 2022
@S11001001 S11001001 mentioned this issue Jun 8, 2022
Merged
1 task
@S11001001 S11001001 added the roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 label Jun 8, 2022
@S11001001 S11001001 mentioned this issue Jun 17, 2022
Merged
3 tasks
@S11001001 S11001001 self-assigned this Aug 31, 2022
@S11001001 S11001001 mentioned this issue Aug 31, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S11001001 S11001001

Labels
component/js-ecosystem TypeScript and React.js bindings roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

declare retroactive interface implementations in TypeScript digital-asset/daml
1 participant
@S11001001