Add EViewInterface to LF - stub compilation/interpretation in speedy #14486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2022
CHANGELOG_BEGIN CHANGELOG_END
daml-lf/archive/src/main/protobuf/com/daml/daml_lf_dev/daml_lf_1.proto
Outdated
Show resolved
Hide resolved
akrmn
reviewed
Jul 21, 2022
| iface <- inWorld (lookupInterface iface) | ||
| unless (alphaType (intView iface) viewtype) $ | ||
| throwWithContext ETypeMismatch{foundType = viewtype, expectedType = intView iface, expr = Nothing} | ||
| checkExpr expr (TCon template) |
There was a problem hiding this comment.
I'm not sure what type we want for the argument here, but ECallInterface takes a TCon iface
Suggested change
| checkExpr expr (TCon template) | |
| checkExpr expr (TCon iface) |
@remyhaemmerle-da what do you think?
There was a problem hiding this comment.
The view construct should be applied to an interface. In general when trying to get the view, we do not know the actual type of the template.
As explained in my previous comment, I think the definition of EViewInterface should be simplify to something like.
EViewInterface
{ viewInterfaceInterface :: !(Qualified TypeConName)
, viewInterfaceExpr :: !Expr
}
akrmn
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
the haskell changes look good to me but please consider @remyhaemmerle-da's point about the information present/needed in the ECallInterface expression constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add EViewInterface as a possible expression type.
Calls to
viewwill be desugared to this construct in a separate PR, #14456 .