Convert viewtype and view methods to LF #14456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
force-pushed
the
interface-views-lfconversion
branch
6 times, most recently
from
3486299 to
fe85d96
Compare
dylant-da
force-pushed
the
interface-views-lfconversion
branch
2 times, most recently
from
f9756c0 to
44f368a
Compare
dylant-da
force-pushed
the
interface-views-lfconversion
branch
4 times, most recently
from
a7de08b to
053c0bc
Compare
dylant-da
force-pushed
the
interface-views-lfconversion
branch
2 times, most recently
from
4515960 to
daffa51
Compare
|
Marking this ready for review. Git tells me that there are ~128 lines worth of changes to non-daml/non-expected files. There are a few daml files with non-trivial changes, but most of them add unit viewtypes. |
dylant-da
requested review from
stefanobaghino-da,
a team,
hrischuk-da,
ray-roestenburg-da,
garyverhaegen-da,
S11001001,
remyhaemmerle-da and
akrmn
as code owners
dylant-da
force-pushed
the
interface-views-lfconversion
branch
from
950ba61 to
eb0d080
Compare
akrmn
reviewed
Aug 3, 2022
| @@ -161,3 +164,10 @@ _exerciseInterfaceGuard : forall i t. | |||
| ContractId t -> (t -> Bool) -> i -> Bool | |||
| _exerciseInterfaceGuard cid tpred ivalue = | |||
| tpred (unsafeFromInterface (coerceContractId cid) ivalue) | |||
|
|
|||
| -- Read: Interface `i` has a view of type `v` | |||
| class HasInterfaceView i v | i -> v where | |||
There was a problem hiding this comment.
ah yes this makes more sense here, thanks
akrmn
reviewed
Aug 3, 2022
| @@ -9,6 +9,7 @@ import DA.Assert ((===)) | |||
|
|
|||
| -- | An interface comment. | |||
| interface Token where | |||
| viewtype () | |||
There was a problem hiding this comment.
this made me wonder, would users get an error for trying to define a method named view?
akrmn
reviewed
Aug 3, 2022
| @@ -85,8 +101,8 @@ Empty Interfaces | |||
| :end-before: -- EMPTY_INTERFACE_END | |||
|
|
|||
| - It is possible (though not necessarily useful) to define an interface without | |||
| methods, precondition or choices. In such a case, the ``where`` keyword | |||
| can be dropped. | |||
| methods, precondition or choices. However, a view type must always be defined, | |||
There was a problem hiding this comment.
thanks for updating the docs :)
cocreature
approved these changes
Aug 3, 2022
daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/InterfaceViewSpec.scala
Outdated
Show resolved
Hide resolved
akrmn
reviewed
Aug 3, 2022
akrmn
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Looks good to me other than
- (these two can be addressed in future PRs)
- error message for trying to
definedeclare a method namedviewin an interface (not in animplementsblock) - moving the interface declarations checks to da-ghc
- error message for trying to
- @cocreature's point about
computeInterfaceView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements LF conversion, and typechecks the generated LF.
Builds on #14456 and #14439, will constitute fewer lines when those PRs are merged.