remove inherited choices from Scala codegen, test interface/template IDs #14113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
added
component/scala-ecosystem
Base automatically changed from
13925-scala-codegen-template-interface-coercion
to
main
June 7, 2022 16:55
CHANGELOG_BEGIN - [Scala codegen] Interface choices can no longer be invoked directly on template IDs, or via ``createAnd`` or ``key`` directly. Instead, use ``toInterface[Ifn]`` before calling the relevant ``exercise*`` method. The resulting ledger commands now contain the correct interface ID rather than template ID for looking up the choice, but see #13993 for a caveat regarding create-and-exercise and exercise-by-key. CHANGELOG_END
stephencompall-DA
force-pushed
the
13926-scala-no-inherited-choices
branch
from
338ca96 to
0ae3a0f
Compare
ray-roestenburg-da
approved these changes
Jun 8, 2022
tudor-da
pushed a commit
that referenced
this pull request
Jun 8, 2022
…IDs (#14113) * inherited choices are gone, convert to interface * use toInterface for conformance tests on interfaces CHANGELOG_BEGIN - [Scala codegen] Interface choices can no longer be invoked directly on template IDs, or via ``createAnd`` or ``key`` directly. Instead, use ``toInterface[Ifn]`` before calling the relevant ``exercise*`` method. The resulting ledger commands now contain the correct interface ID rather than template ID for looking up the choice, but see #13993 for a caveat regarding create-and-exercise and exercise-by-key. CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13926.