Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toInterface and unsafeToTemplate in Scala codegen #13991

Merged
merged 14 commits into from
Jun 7, 2022
Merged

toInterface and unsafeToTemplate in Scala codegen #13991

merged 14 commits into from
Jun 7, 2022

Conversation

S11001001
Copy link
Contributor

@S11001001 S11001001 commented May 26, 2022 •
edited
Loading

Fixes #13925.

CHANGELOG_BEGIN
- [Scala codegen] Template contract IDs and interface contract IDs have
  new coercion methods, ``toInterface`` and ``unsafeToTemplate``,
  respectively.

  ``toInterface`` can also be used with ``createAnd`` as well as ``key``
  for create-and-exercise and exercise-by-key respectively; however, see
  #13993 for a caveat regarding ledger API support.
CHANGELOG_END

@S11001001 S11001001 added component/scala-ecosystem Scala development experience team/ledger-clients Related to the Ledger Clients team's components. labels May 26, 2022
@S11001001 S11001001 self-assigned this May 26, 2022
@S11001001 S11001001 changed the title contract ID coercion in Scala codegen toInterface and unsafeToTemplate in Scala codegen May 26, 2022
@S11001001 S11001001 linked an issue May 26, 2022 that may be closed by this pull request
toInterface and unsafeToTemplate extension methods #13925
Closed
6 tasks
@S11001001 S11001001 marked this pull request as ready for review May 26, 2022 22:23
@S11001001 S11001001 requested a review from a team May 26, 2022 22:23
@stephencompall-DA stephencompall-DA force-pushed the 13925-scala-codegen-template-interface-coercion branch from 401740a to f938acf Compare May 31, 2022 14:27
Base automatically changed from 13924-scala-codegen-interface-types to main June 7, 2022 14:30
S11001001 added 14 commits June 7, 2022 11:29
@S11001001
Template.Implements marker, and toInterface for contract IDs
a307a38
@S11001001
unsafeToTemplate for interface contract IDs
7b5295b
@S11001001
note some wrong command arguments
0a1d68b
@S11001001
toInterface for create-and-exercise, exercise by key
c7198fc
@S11001001
fix sample code for Scala 2.13
3259526
@S11001001
generate Implements instances and test contract ID coercion
a33c5b9
@S11001001
pass along TemplateCompanion for two-IDed create-and-exercise and exe…
6c8a974 
…rcise-by-key
@S11001001
test CreateAndExerciseCommand for post-interface-coercion
c5d5764
@S11001001
simplify toInterface for by-key and create-and
36293ad
@S11001001
create-and might not need origin evidence
30bc209
@S11001001
test that exercise-by-key uses template ID even with interface choices
5e2749a
@S11001001
separate issue for interface ID passing, #13993
fd9f993
@S11001001
scaladoc for toInterface, unsafeToTemplate
10b6109
@S11001001
add changelog
2b5486f 
CHANGELOG_BEGIN
- [Scala codegen] Template contract IDs and interface contract IDs have
  new coercion methods, ``toInterface`` and ``unsafeToTemplate``,
  respectively.

  ``toInterface`` can also be used with ``createAnd`` as well as ``key``
  for create-and-exercise and exercise-by-key respectively; however, see
  #13993 for a caveat regarding ledger API support.
CHANGELOG_END
@stephencompall-DA stephencompall-DA force-pushed the 13925-scala-codegen-template-interface-coercion branch from f938acf to 2b5486f Compare June 7, 2022 15:30
@S11001001 S11001001 enabled auto-merge (squash) June 7, 2022 15:32
@S11001001 S11001001 mentioned this pull request Jun 7, 2022
Merged
3 tasks
@S11001001 S11001001 merged commit 15b82ef into main Jun 7, 2022
@S11001001 S11001001 deleted the 13925-scala-codegen-template-interface-coercion branch June 7, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

Assignees

@S11001001 S11001001

Labels
component/scala-ecosystem Scala development experience team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toInterface and unsafeToTemplate extension methods
2 participants
@S11001001 @ray-roestenburg-da