Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two-phase create-and-exercise with unified exercise methods in Java #14037

Merged
merged 34 commits into from
Jun 2, 2022
Merged

two-phase create-and-exercise with unified exercise methods in Java #14037

merged 34 commits into from
Jun 2, 2022

Conversation

S11001001
Copy link
Contributor

@S11001001 S11001001 commented May 31, 2022 •
edited
Loading

Fixes #13920.

CHANGELOG_BEGIN
- [Java codegen] ``createAndExercise*`` and ``exerciseByKey*`` methods
  are deprecated; instead, use the new ``createAnd().exercise*`` and
  ``byKey(key).exercise*`` methods.

  When the ledger API supports it, interface choices will be reachable
  via ``createAnd().toInterface(Ifc.INTERFACE).exercise*`` and
  ``byKey(key).toInterface(Ifc.INTERFACE).exercise*``, exactly the
  syntax supported by contract-ID exercise; see #14056.
CHANGELOG_END

@S11001001 S11001001 added component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components. labels May 31, 2022
@S11001001 S11001001 self-assigned this May 31, 2022
@S11001001 S11001001 linked an issue May 31, 2022 that may be closed by this pull request
unified by-contract-ID/createAnd exercise interface, deprecate createAndExercise methods #13920
Closed
9 tasks
@S11001001 S11001001 marked this pull request as ready for review June 1, 2022 19:23
@S11001001 S11001001 requested a review from a team June 1, 2022 19:23
Base automatically changed from 13919-to-interface-overloads-java-codegen to main June 2, 2022 10:28
S11001001 added 18 commits June 2, 2022 07:09
@S11001001
add ContractTypeCompanion and Exercises support classes
27d5a77
@S11001001
new getCompanion methods generated for contract IDs
4f0f7d7
@S11001001
generate template ID for interface companion
6403b78
@S11001001
narrow ContractTypeCompanion
28798e2
@S11001001
add CreateAnd parent
db2f9f3
@S11001001
generate Exercises and inherit it in ContractId
6250f3e
@S11001001
make every Exercises public
845a568
@S11001001
CreateAnd classes for templates and interfaces
5bbd85c
@S11001001
use generateToInterfaceMethods at its origin
548463c
@S11001001
add createAnd() method to set up
e035751
@S11001001
add a deprecation annotation and Javadoc note
a7812f3
@S11001001
turn deprecated createAndExercise into forwarders
adebe8a
@S11001001
deprecate flattened createAndExercise instance methods, too
2fa642d
@S11001001
note that methods are deprecated in their generator functions
01f80b1
@S11001001
note more methods are deprecated in their generator functions
87c8e40
@S11001001
introduce ByKey base for exercise-by-key
a382348
@S11001001
link to #14039
27d1ba6
@S11001001
start of by-key generation
662d309
S11001001 added 16 commits June 2, 2022 07:09
@S11001001
mark CreateAnd final
99af70e
@S11001001
generate ByKey classes and byKey methods
aa7b29a
@S11001001
syntax for nicer deprecations
f6b0616
@S11001001
add generated code for by-key/interface interaction
7572ced
@S11001001
javadoc for byKey
a81eb34
@S11001001
more Scalaesque docstring
5f3f216
@S11001001
deprecate and forward static by-key exercise methods
8e2f364
@S11001001
@code in deprecation doc
c0544f3
@S11001001
rename functions to emphasize deprecation
66a10a4
@S11001001
link to #14039
959218c
@S11001001
make both template and interface ID available for CreateAnd
7427d0d
@S11001001
make both template and interface ID available for ByKey
2be0f63
@S11001001
add changelog
5d5c4c9 
CHANGELOG_BEGIN
- [Java codegen] ``createAndExercise*`` and ``exerciseByKey*`` methods
  are deprecated; instead, use the new ``createAnd().exercise*`` and
  ``byKey(key).exercise*`` methods.

  When the ledger API supports it, interface choices will be reachable
  via ``createAnd().toInterface(Ifc.INTERFACE).exercise*`` and
  ``byKey(key).toInterface(Ifc.INTERFACE).exercise*``, exactly the
  syntax supported by contract-ID exercise; see #14056.
CHANGELOG_END
@S11001001
document new output for exercise methods
c4a1f53
@S11001001
javadoc for CreateAnd, ByKey
0654ae9
@S11001001
reformat
43ef7ea
@stephencompall-DA stephencompall-DA force-pushed the 13920-java-two-phase-createAnd branch from 9bbe6d0 to 43ef7ea Compare June 2, 2022 11:11
@S11001001 S11001001 enabled auto-merge (squash) June 2, 2022 11:14
@S11001001 S11001001 merged commit 4f7eefc into main Jun 2, 2022
@S11001001 S11001001 deleted the 13920-java-two-phase-createAnd branch June 2, 2022 12:10
@S11001001 S11001001 mentioned this pull request Jul 15, 2022
Open
@S11001001 S11001001 mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees

@S11001001 S11001001

Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unified by-contract-ID/createAnd exercise interface, deprecate createAndExercise methods
2 participants
@S11001001 @ray-roestenburg-da