Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified by-contract-ID/createAnd exercise interface, deprecate createAndExercise methods #13920

Closed
9 tasks done
Tracked by #13921 ...
S11001001 opened this issue May 18, 2022 · 0 comments · Fixed by #14037
Closed
9 tasks done
Tracked by #13921 ...
Assignees
Labels
component/java-ecosystem Java development experience roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

S11001001 commented May 18, 2022

Design from #13668 (comment) . For this part:

  • declare codegen.Exercises<Cmd> with makeExerciseCmd
  • implement makeExerciseCmd in codegen.ContractId which now implements Exercises<ExerciseCommand>
  • define codegen.CreateAnd<...> implements Exercises<CreateAndExerciseCommand>
  • define createAnd() on templates
  • move exercise methods from ContractId to separate generated interface with default methods in terms of makeExerciseCmd
  • define codegen.ByKey<...> implements Exercises<ExerciseByKeyCommand>
  • define static byKey(...) in terms of ByKey and Exercises
  • propagate extra TemplateId in the toInterface cases for create-and, by-key
  • emit deprecation annotation and maybe Javadoc for all existing createAndExercise and by-key methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/java-ecosystem Java development experience roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants