ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] #12454

ghost · 2022-01-18T10:57:45Z

Rather than making it optional, we can expose a feature that instructs whether we support certain kinds of contract IDs.

This works for Canton too as it defaults to "SUFFIXED".

Changelog

[Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the StandaloneApiService accordingly.

Pull Request Checklist

Read and understand the contribution guidelines
Include appropriate tests
Set a descriptive title and thorough description
Add a reference to the issue this PR will solve, if appropriate
Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
Normal production system change, include purpose of change in description
If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Rather than making it optional, we can expose a feature that instructs whether we support certain kinds of contract IDs. This accidentally works for Canton too as it defaults to "false" for both options, which holds for Canton. CHANGELOG_BEGIN - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. CHANGELOG_END

fabiotudone-da

LGTM, perhaps you'll need to adjust compatibility exclusions and enable a full run?

meiersi-da · 2022-01-18T11:26:50Z

ledger-api/grpc-definitions/com/daml/ledger/api/v1/experimental_features.proto

+message ContractIdFeatures {
+  bool v0_supported = 1;
+  bool v1_non_suffixed_supported = 2;
+}


@SamirTalwar-DA please add comments here that are detailed enough for any of our engineers to understand what the two features are and which ones are expected to be supported.

I'd expect something along one or two sentences per field and a pointer to the details which are likely present in either the test code or the LF infrastructure code.

Also: right now the default value of this message is such that none of the two modes are supported, which means that by default none of the corresponding tests are run. Is there the option to choose a reasonable default that works for Canton out of the box, and thereby ensure that on upgrade the test tool will always test their supported contact-ids?

fyi v0 contract IDs will be dropped with Daml 2.0, so you could drop the corresponding tests.
language-team can take care of it, when we effectively drop the support.
At least it does not seems useful to add a feature for v0.

I link the issue #11322

Probably worth add a referent to the Contract ID spec.

KV also supports both kinds of v1 CIDs. I am not sure if that's intentional, but it does.

(You can see this in the ledger-on-memory diff; we used to explicitly enable the tests accordingly.)

"--additional=ContractIdIT:RejectV0,ContractIdIT:AcceptSuffixedV1,ContractIdIT:AcceptNonSuffixedV1",

@remyhaemmerle-da, @meiersi-da, please take another look when you have a moment. I think it's clearer now.

I removed the v0 contract ID feature flag and the associated test cases.

This doesn’t make sense to me. We should still test that v0 contract ids are rejected especially if we’re dropping support for them. What we can drop is the test that they’re accepted.

I think it makes complelty sens to drop the conformance tests for rejection of V0 contract IDs, if we drop their support soonish. Once the support is complelty drop, rejection of those CIDs does not need to be done at the conformance levels, but could be checked at the unit test level one: We just have to check that de serialization failed for those CIDs.

I am fine to keep the tests that check for rejections for now, and drop them only once the support is removed, thought,
We still should drop test for acceptance of V0 CIDs. No need for the remaining test to be penetrable, all supported ledger should reject V0 CIDs.

run-full-compat: true

We also remove the tests for v0 contract IDs from ContractIdIT.

hubert-da · 2022-01-18T16:07:30Z

compatibility/bazel_tools/testing.bzl

+        # Contract ID tests are governed by feature descriptors.
+        "platform_ranges": [
+            {
+                "end": "2.0.0-snapshot.20220110.8812.1",


Just to make sure, ContractIdIT is not going to be run with any ledger-api-test-tool version against platform versions older than the next snapshot. Is that what you want?

Yes, this reproduces the old behavior, where these tests were optional and therefore not run.

…-tool/contract-id-features

remyhaemmerle-da

ContractIdIT.scala looks good to me.

cocreature

Requesting changes until the v0 rejection tests are back, sorry for the confusion

cocreature · 2022-01-19T08:18:08Z

ledger/sandbox-on-x/src/main/scala/com/daml/ledger/sandbox/SandboxOnXRunner.scala

@@ -256,6 +257,10 @@ object SandboxOnXRunner {
        deduplicationType = CommandDeduplicationType.SYNC_ONLY,
        maxDeduplicationDurationEnforced = false,
      ),
+      contractIdFeatures = ContractIdFeatures.of(
+        v0 = ContractIdFeatures.ContractIdV0Support.SUPPORTED,


sandbox on x should not support v0 I think, only v1.

remyhaemmerle-da · 2022-01-19T08:20:07Z

...r/ledger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/suites/ContractIdIT.scala

+      description = "v0",
+      example = v0Cid,
+      accepted = true,
+      isSupported = features => features.contractIds.v0.isSupported,


Suggested change

isSupported = features => features.contractIds.v0.isSupported,

isSupported = features => false,

So we never want to run this test case?

We do not have any ledger that support V0.
Sandbox classic was the only one, and it is gone.

sandbox classic and sandbox on x are both still in the repo and support it. Let’s not change that in this PR and instead separately drop support.

remyhaemmerle-da · 2022-01-19T08:20:21Z

...r/ledger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/suites/ContractIdIT.scala

+    TestConfiguration(
+      description = "v0",
+      example = v0Cid,
+      accepted = false,
+      isSupported = features => features.contractIds.v0.isNotSupported,
+      disabledReason = "V0 contract IDs are supported",


Suggested change

TestConfiguration(

description = "v0",

example = v0Cid,

accepted = false,

isSupported = features => features.contractIds.v0.isNotSupported,

disabledReason = "V0 contract IDs are supported",

I think you meant that the other one should be deleted. This one asserts that v0 contract IDs are rejected.

My mistake.

remyhaemmerle-da · 2022-01-19T08:20:57Z

ledger-api/grpc-definitions/com/daml/ledger/api/v1/experimental_features.proto

@@ -71,7 +71,13 @@ enum CommandDeduplicationType {

 // See `daml-lf/spec/contract-id.rst` for more information on contract ID formats.
 message ContractIdFeatures {
-  ContractIdV1Support v1 = 1;
+  ContractIdV0Support v0 = 1;


We do not really need a feature for V0. V0 should be rejected by all supported ledgers.
I think what @cocreature want is that we check that V0 is always rejected, but we can drop the tests that check V0 is supported.

Currently Sandbox-on-X supports v0. Should we change this?

(I would prefer not to change this as part of this PR.)

we should but agreed, let’s do it in a separate PR.

…-tool/contract-id-features

We can't exclude a test until it exists. run-full-compat: true

ghost · 2022-01-19T21:40:07Z

Merging this but comments are still welcome.

@adriaanm-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @adriaanm-da is in charge of this release. Commit log: ``` 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ebd3827 Make UserId properly opaque by defining it as a variant (#12476) 3159d60 LF: more tests for evaluation order of fetch (#12471) 96f454a update compat versions for 1.18.1 (#12430) 82639a1 Fix get-daml.sh installation script (#12487) e222c35 Enhance conformance test: ACS coverage [DPP-672] (#11334) 2443891 Remove /user/delete GET endpoint (#12486) 681f8fc Add missing serializability checks for interfaces (#12483) 7c59728 Remove reset service support from the storage backend [DPP-804] (#12477) f7e2faf [User management] Addressing outstanding code review comments from #12344 (#12479) 350fe5c Update RELEASE.md (#12481) 82534f9 Remove the reset service from the ledger api and the documentation [DPP-804] (#12472) 4885e61 rotate release duty after 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12468) 9518f15 Fix sandbox on x compat test switch (#12478) 66494a2 [User management] created_at and granted_at in Oracle (#12417) 6fbaac4 Remove user-management error cases from scenario-service proto. (#12460) 1f1e8bf [DPP-829] Make ledger-id field optional in requests (#12243) 74e9efc release 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12467) d0cbccb Explicitly name coalesced columns (#12377) 954bc5e Remove the reset service from sandbox-classic and sandbox [DPP-804] (#12448) e40c221 Fix compatibility tests. (#12465) ``` Changelog: ``` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. - [HTTP-JSON] Removed the /user/delete GET endpoint. Please use the /user/delete POST endpoint with the own user ID if you need to delete the user associated with the current token Remove reset service from the ledger api protocol and the documentation The field "ledger_id" in all request to Participant API is now optional (was required). Reset service has been removed from the sandbox-classic, sandbox and daml-on-sql ``` CHANGELOG_BEGIN CHANGELOG_END

@adriaanm-da

* release 2.0.0-snapshot.20220126.9013.0.54339ada This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @adriaanm-da is in charge of this release. Commit log: ``` 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ebd3827 Make UserId properly opaque by defining it as a variant (#12476) 3159d60 LF: more tests for evaluation order of fetch (#12471) 96f454a update compat versions for 1.18.1 (#12430) 82639a1 Fix get-daml.sh installation script (#12487) e222c35 Enhance conformance test: ACS coverage [DPP-672] (#11334) 2443891 Remove /user/delete GET endpoint (#12486) 681f8fc Add missing serializability checks for interfaces (#12483) 7c59728 Remove reset service support from the storage backend [DPP-804] (#12477) f7e2faf [User management] Addressing outstanding code review comments from #12344 (#12479) 350fe5c Update RELEASE.md (#12481) 82534f9 Remove the reset service from the ledger api and the documentation [DPP-804] (#12472) 4885e61 rotate release duty after 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12468) 9518f15 Fix sandbox on x compat test switch (#12478) 66494a2 [User management] created_at and granted_at in Oracle (#12417) 6fbaac4 Remove user-management error cases from scenario-service proto. (#12460) 1f1e8bf [DPP-829] Make ledger-id field optional in requests (#12243) 74e9efc release 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12467) d0cbccb Explicitly name coalesced columns (#12377) 954bc5e Remove the reset service from sandbox-classic and sandbox [DPP-804] (#12448) e40c221 Fix compatibility tests. (#12465) ``` Changelog: ``` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. - [HTTP-JSON] Removed the /user/delete GET endpoint. Please use the /user/delete POST endpoint with the own user ID if you need to delete the user associated with the current token Remove reset service from the ledger api protocol and the documentation The field "ledger_id" in all request to Participant API is now optional (was required). Reset service has been removed from the sandbox-classic, sandbox and daml-on-sql ``` CHANGELOG_BEGIN CHANGELOG_END * bump release commit changelog_begin changelog_end Co-authored-by: Azure Pipelines Daml Build <[email protected]> Co-authored-by: Moritz Kiefer <[email protected]>

@stefanobaghino-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @stefanobaghino-da is in charge of this release. Commit log: ``` 42cf70b ci: try to fix release process (#12600) 0579ebd Mark the `withExpectedLedgerId` method in `DamlLedgerClient.Builder` as deprecated (#12537) deb7f3a Move some trigger compat tests to sandbox-on-x (#12598) 5cdf9b9 Remove some unecessary `implictly` with `Factory` (#12559) 9c3f1ce Drop dummy token from JSON API check (#12593) 3366c6f compatibility: Exclude another command deduplication test. (#12592) 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ebd3827 Make UserId properly opaque by defining it as a variant (#12476) 3159d60 LF: more tests for evaluation order of fetch (#12471) 96f454a update compat versions for 1.18.1 (#12430) 82639a1 Fix get-daml.sh installation script (#12487) e222c35 Enhance conformance test: ACS coverage [DPP-672] (#11334) 2443891 Remove /user/delete GET endpoint (#12486) 681f8fc Add missing serializability checks for interfaces (#12483) 7c59728 Remove reset service support from the storage backend [DPP-804] (#12477) f7e2faf [User management] Addressing outstanding code review comments from #12344 (#12479) 350fe5c Update RELEASE.md (#12481) 82534f9 Remove the reset service from the ledger api and the documentation [DPP-804] (#12472) 4885e61 rotate release duty after 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12468) 9518f15 Fix sandbox on x compat test switch (#12478) 66494a2 [User management] created_at and granted_at in Oracle (#12417) 6fbaac4 Remove user-management error cases from scenario-service proto. (#12460) 1f1e8bf [DPP-829] Make ledger-id field optional in requests (#12243) 74e9efc release 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12467) d0cbccb Explicitly name coalesced columns (#12377) 954bc5e Remove the reset service from sandbox-classic and sandbox [DPP-804] (#12448) e40c221 Fix compatibility tests. (#12465) ``` Changelog: ``` [Java bindings] Deprecate `DamlLedgerClient.Builder.withExpectedLedgerId` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. - [HTTP-JSON] Removed the /user/delete GET endpoint. Please use the /user/delete POST endpoint with the own user ID if you need to delete the user associated with the current token Remove reset service from the ledger api protocol and the documentation The field "ledger_id" in all request to Participant API is now optional (was required). Reset service has been removed from the sandbox-classic, sandbox and daml-on-sql ``` CHANGELOG_BEGIN CHANGELOG_END

@stefanobaghino-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @stefanobaghino-da is in charge of this release. Commit log: ``` 42cf70b ci: try to fix release process (#12600) 0579ebd Mark the `withExpectedLedgerId` method in `DamlLedgerClient.Builder` as deprecated (#12537) deb7f3a Move some trigger compat tests to sandbox-on-x (#12598) 5cdf9b9 Remove some unecessary `implictly` with `Factory` (#12559) 9c3f1ce Drop dummy token from JSON API check (#12593) 3366c6f compatibility: Exclude another command deduplication test. (#12592) 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ebd3827 Make UserId properly opaque by defining it as a variant (#12476) 3159d60 LF: more tests for evaluation order of fetch (#12471) 96f454a update compat versions for 1.18.1 (#12430) 82639a1 Fix get-daml.sh installation script (#12487) e222c35 Enhance conformance test: ACS coverage [DPP-672] (#11334) 2443891 Remove /user/delete GET endpoint (#12486) 681f8fc Add missing serializability checks for interfaces (#12483) 7c59728 Remove reset service support from the storage backend [DPP-804] (#12477) f7e2faf [User management] Addressing outstanding code review comments from #12344 (#12479) 350fe5c Update RELEASE.md (#12481) 82534f9 Remove the reset service from the ledger api and the documentation [DPP-804] (#12472) 4885e61 rotate release duty after 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12468) 9518f15 Fix sandbox on x compat test switch (#12478) 66494a2 [User management] created_at and granted_at in Oracle (#12417) 6fbaac4 Remove user-management error cases from scenario-service proto. (#12460) 1f1e8bf [DPP-829] Make ledger-id field optional in requests (#12243) 74e9efc release 2.0.0-snapshot.20220118.8919.0.d0813e61 (#12467) d0cbccb Explicitly name coalesced columns (#12377) 954bc5e Remove the reset service from sandbox-classic and sandbox [DPP-804] (#12448) e40c221 Fix compatibility tests. (#12465) ``` Changelog: ``` [Java bindings] Deprecate `DamlLedgerClient.Builder.withExpectedLedgerId` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. - [HTTP-JSON] Removed the /user/delete GET endpoint. Please use the /user/delete POST endpoint with the own user ID if you need to delete the user associated with the current token Remove reset service from the ledger api protocol and the documentation The field "ledger_id" in all request to Participant API is now optional (was required). Reset service has been removed from the sandbox-classic, sandbox and daml-on-sql ``` CHANGELOG_BEGIN CHANGELOG_END

@stefanobaghino-da

@stefanobaghino-da is in charge of this release changelog: ``` - [Daml Studio] The minimum supported vscode version is now 1.52.0. - [Typescript Bindings] All methods for user management have been added to the bindings (createUser, deleteUser, getUser, listUsers, listUserRights, grantUserRight, revokeUserRight) [Java bindings] Deprecate `DamlLedgerClient.Builder.withExpectedLedgerId` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. ``` commits: ``` 346a61d79c0574f4a045d46b7e39a99217f44da4 release 2.0.0-snapshot.20220127.9042.0.4038d0a7 4038d0a Fix VSCode extension (#12611) 13acf66 Point out to run release manual tests on Windows with the KV sandbox (#12608) 7305a8c Color and typography edits (#12609) 4a6729e Fix a bug in user management caching (#12605) 3e16e5e Handle ledger bridge Queue errors (#12510) b1a9175 ci: reduce Windows capacity (#12607) 53edac1 Move some daml-script compat tests to sandbox-on-x (#12595) 6b902fd [TS-Bindings] Complete support for user management (#12576) f04dcfa release 2.0.0-snapshot.20220126.9029.0.42cf70b1 (#12603) 403efa7 Add support for interfaces through data-dependencies (#12516) ea62021 Upgrade ghcide (#12579) 98e6842 ci: pin Windows folders, step 1 (#12597) 01219d6 ci: temporarily increase Windows capacity (#12599) 42cf70b ci: try to fix release process (#12600) 0579ebd Mark the `withExpectedLedgerId` method in `DamlLedgerClient.Builder` as deprecated (#12537) deb7f3a Move some trigger compat tests to sandbox-on-x (#12598) 5cdf9b9 Remove some unecessary `implictly` with `Factory` (#12559) 9c3f1ce Drop dummy token from JSON API check (#12593) 3366c6f compatibility: Exclude another command deduplication test. (#12592) 6b50abf release 2.0.0-snapshot.20220126.9013.0.54339ada (#12587) ad7148b Tear down daml services gracefully (#12591) 16a4f06 Avoid explicitly listing all Oracle tests in build.yml (#12594) bc9fa28 Make ledger end non-optional (#12570) 122a487 Fix static-time config in Canton (#12584) 7bcce7c Upgrade rules-haskell (#12580) 159f384 Drop 7zip from Windows dev-env (#12590) 215a63d correct deprecated options with newest synopsys-detect version (#12586) 84023ae update NOTICES file (#12589) 79864ef Fix error codes for V1 cid rejections (#12571) 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ``` changelog_begin changelog_end

@stefanobaghino-da

@stefanobaghino-da is in charge of this release changelog: ``` - [Daml Studio] The minimum supported vscode version is now 1.52.0. - [Typescript Bindings] All methods for user management have been added to the bindings (createUser, deleteUser, getUser, listUsers, listUserRights, grantUserRight, revokeUserRight) [Java bindings] Deprecate `DamlLedgerClient.Builder.withExpectedLedgerId` Transaction Metering now persisted to database - [Ledger API Test Tool] More command deduplication tests have been enabled by default. This should not affect testing a fully functioning ledger. If any tests fail, they can be temporarily excluded. - [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload - [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user Add experimental Daml assistant support for ledger metering [Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed. - [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT`` and ``TransactionScaleIT``, have been removed in favor of more targeted benchmarking tests. If you are actively including these tests in your test run, you will need to remove them. These tests are disabled by default so it is likely that no change will be needed. - [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has been enabled by default. You may need to disable specific test cases accordingly. Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature. - [Ledger API Test Tool] The ``MultiPartySubmissionIT`` test case has been enabled by default. You will most likely not need to change anything. - [Ledger API Test Tool] The "ContractIdIT" test is now run by default, using ledger feature flags to determine which test cases are run. You will need to configure the ``StandaloneApiService`` accordingly. ``` commits: ``` 346a61d79c0574f4a045d46b7e39a99217f44da4 release 2.0.0-snapshot.20220127.9042.0.4038d0a7 4038d0a Fix VSCode extension (#12611) 13acf66 Point out to run release manual tests on Windows with the KV sandbox (#12608) 7305a8c Color and typography edits (#12609) 4a6729e Fix a bug in user management caching (#12605) 3e16e5e Handle ledger bridge Queue errors (#12510) b1a9175 ci: reduce Windows capacity (#12607) 53edac1 Move some daml-script compat tests to sandbox-on-x (#12595) 6b902fd [TS-Bindings] Complete support for user management (#12576) f04dcfa release 2.0.0-snapshot.20220126.9029.0.42cf70b1 (#12603) 403efa7 Add support for interfaces through data-dependencies (#12516) ea62021 Upgrade ghcide (#12579) 98e6842 ci: pin Windows folders, step 1 (#12597) 01219d6 ci: temporarily increase Windows capacity (#12599) 42cf70b ci: try to fix release process (#12600) 0579ebd Mark the `withExpectedLedgerId` method in `DamlLedgerClient.Builder` as deprecated (#12537) deb7f3a Move some trigger compat tests to sandbox-on-x (#12598) 5cdf9b9 Remove some unecessary `implictly` with `Factory` (#12559) 9c3f1ce Drop dummy token from JSON API check (#12593) 3366c6f compatibility: Exclude another command deduplication test. (#12592) 6b50abf release 2.0.0-snapshot.20220126.9013.0.54339ada (#12587) ad7148b Tear down daml services gracefully (#12591) 16a4f06 Avoid explicitly listing all Oracle tests in build.yml (#12594) bc9fa28 Make ledger end non-optional (#12570) 122a487 Fix static-time config in Canton (#12584) 7bcce7c Upgrade rules-haskell (#12580) 159f384 Drop 7zip from Windows dev-env (#12590) 215a63d correct deprecated options with newest synopsys-detect version (#12586) 84023ae update NOTICES file (#12589) 79864ef Fix error codes for V1 cid rejections (#12571) 54339ad Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573) 5cccec2 release: use-devenv (#12583) 90aacea split-release (#12577) cc19df4 Persist transaction metering info [DPP-814,DPP-821] (#12274) cb77c84 damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581) ed33c0d split: flat(ter) files in Artifactory (#12575) e355832 split: do not push exe (#12574) 0afc4a5 split: do not tag (#12569) ebf7908 LF: check contracts are consumed when found them in the cache (#12527) ce06eb0 Add serializability check for interface payloads in Haskell (#12560) aced78f Drop dadew uninstall (#12566) ac3ca1d ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541) 5f58698 [JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352) 42aadec Cleanup Haskell serializability check (#12565) 5d93eb9 Engine stacktraces are disabled by default (#12562) 42d86ac [User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503) 13153de update NOTICES file (#12564) 5bfe4ed Wait for server process in client_server_test (#12551) f1cd4b1 Remove dependencies on compatibility libraries (#12548) dcd721d Drop scenarios (#12484) 170d839 Fix es (#12554) 8fa54c6 Experimental daml assistant support for metering report [DPP-816] (#12485) 9802028 Cut a new split release (#12547) aec3390 Replace silencer plugin with built-in warning configuration (#12543) 93cfe04 Remove from the Java bindings constructors that were deprecated since 0.x (#12536) 8d65aa3 Remove Sandbox classic stores and related unit tests (#12532) 24b2325 Bump node-fetch to address dependabot alerts (#12553) fdb034c split-release: Canton dependencies to public GCS (#12552) 3f8ec07 Upgrade to the latest Canton snapshot (#12544) 8692d80 Fix trigger compat test for canton sandbox (#12549) 3ea8ade LF: Test evaluation order of exercise and exercise_by_key (#12519) 36f8d67 Upgrade `css-loader` to 5.2.7 (#12550) a150737 Upgrade msys2 (#12545) 01447fd docs: typos and minor clarification for authz docs (#12534) fbf244e alert on invalid users in create-daml-app (#12518) f2b4abe update NOTICES file (#12542) bd0ae02 Startup initialization header for runners [DPP-860] (#12525) 15c0ad7 Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517) 7218e6f ledger-api-test-tool: Remove retired tests. (#12535) cbb4986 Add Empty GRPC Metering Report Service [DPP-856] (#12515) 4d26f08 ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529) 3044958 ledger-api-test-tool: Remove deprecated options. (#12533) 5ab9eae Make mutable-contract-state-cache the default and only option (#12528) 89d95e6 user management: allow ':' in user ids (#12531) f5d7821 compatibility: Disable MultiParticipantIT for old versions. (#12526) 2deeabf [User management] Add feature flag to enable user management [DPP-827] (#12420) b843117 Drop feature flag for v0 cid support (#12522) 73277f4 Upgrade to oracle 19.14 image for ci (#12523) cdde8df ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462) 2267d1a sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466) 20cda01 specify that deduplication offsets are exclusive (#12488) e9e1b06 ledger-api-test-tool: Enable `MultiPartySubmissionIT` for everyone. [KVL-1261] (#12500) a5f56e0 Use canton sandbox in script+trigger compat tests (#12514) 9c03e79 Build create-daml-app with -Werror (#12513) 688f1e1 Drop v0 contract ids (#12464) c35d34d Remove ResetService from the grpc documentation (#12512) eb61893 resources: Remove ResettableResourceOwner. (#12499) 7880d54 Add --port-file and --dar flags in daml sandbox (#12505) 3c8a646 Tell users to use --install-assistant=yes (#12507) 36536fa LF: Test evaluation order of lookup_by_key (#12494) ad7ce54 participant-integration-api: Factor out feature flags into a class. (#12496) 4d698c1 Update windows testing instructions (#12504) 0f8e40c user management: add reference docs (#12398) 96b8651 Drop orphaned vim syntax files (#12502) a644406 Avoid stale DAML_SDK_VERSION_LATEST in assistant (#12493) 7a1b37c [User management] Nullable primary_party and for_party (#12419) cd30f01 update NOTICES file (#12498) b11f11b Drop support for no seeding in sandbox-classic (#12495) 5d2be1e ledger-api-test-tool-on-canton: Use `join` to clean up exclusions. (#12497) 072d57a DPP-553 Consistently use anorm string interpolation (#12266) f03fa6a ledger-api-test-tool: Govern ContractIdIT test runs through a feature. (#12454) dd4fc1f split release (#12492) de2a8c0 ci: use service account for Windows nodes (#12489) 644efd1 Lower log level to warn (#12490) ``` changelog_begin changelog_end

SamirTalwar added 2 commits January 18, 2022 11:42

ledger-api-test-tool: Rename "ParticipantFeature" to "Features".

4246e89

ghost requested review from meiersi-da and a team as code owners January 18, 2022 10:57

ghost requested a review from remyhaemmerle-da January 18, 2022 10:58

fabiotudone-da approved these changes Jan 18, 2022

View reviewed changes

meiersi-da reviewed Jan 18, 2022

View reviewed changes

SamirTalwar added 2 commits January 18, 2022 14:47

ledger-api: Add some documentation to ContractIdFeatures.

327c85f

compatibility: Update for ContractIdIT.

b5bdaca

run-full-compat: true

ghost requested review from cocreature and garyverhaegen-da as code owners January 18, 2022 14:59

ledger-api: Clarify the contract ID features and remove v0 support.

5e9f68c

We also remove the tests for v0 contract IDs from ContractIdIT.

hubert-da reviewed Jan 18, 2022

View reviewed changes

Merge remote-tracking branch 'origin/main' into samir/ledger-api-test…

ce8018c

…-tool/contract-id-features

remyhaemmerle-da reviewed Jan 18, 2022

View reviewed changes

remyhaemmerle-da mentioned this pull request Jan 18, 2022

Kill V0 contract ids #11322

Closed

cocreature requested changes Jan 18, 2022

View reviewed changes

SamirTalwar added 2 commits January 19, 2022 09:01

ledger-api-test-tool: Re-introduce tests for v0 contract IDs.

92f0228

ledger-api-test-tool: Case class with named parameters in ContractIdIT.

60ef499

cocreature reviewed Jan 19, 2022

View reviewed changes

cocreature approved these changes Jan 19, 2022

View reviewed changes

remyhaemmerle-da reviewed Jan 19, 2022

View reviewed changes

SamirTalwar added 3 commits January 19, 2022 15:26

Merge remote-tracking branch 'origin/main' into samir/ledger-api-test…

0e65a57

…-tool/contract-id-features

ledger-api: All ledgers must support suffixed contract IDs.

26756db

compatibilty: Add a start for ContractIdIT.

31ef1b1

We can't exclude a test until it exists. run-full-compat: true

ghost merged commit f03fa6a into main Jan 19, 2022

ghost deleted the samir/ledger-api-test-tool/contract-id-features branch January 19, 2022 21:40

ghost changed the title ~~ledger-api-test-tool: Govern ContractIdIT test runs through a feature.~~ ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] Jan 19, 2022

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] #12454

ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] #12454

ghost commented Jan 18, 2022 •

edited by ghost

Loading

fabiotudone-da left a comment

meiersi-da Jan 18, 2022 •

edited

Loading

meiersi-da Jan 18, 2022

meiersi-da Jan 18, 2022

remyhaemmerle-da Jan 18, 2022 •

edited

Loading

remyhaemmerle-da Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

cocreature Jan 18, 2022

remyhaemmerle-da Jan 18, 2022 •

edited

Loading

hubert-da Jan 18, 2022

ghost Jan 18, 2022

remyhaemmerle-da left a comment

cocreature left a comment

cocreature Jan 19, 2022

remyhaemmerle-da Jan 19, 2022

ghost Jan 19, 2022

remyhaemmerle-da Jan 19, 2022 •

edited

Loading

cocreature Jan 19, 2022

remyhaemmerle-da Jan 19, 2022

ghost Jan 19, 2022

remyhaemmerle-da Jan 19, 2022

remyhaemmerle-da Jan 19, 2022

cocreature Jan 19, 2022

ghost Jan 19, 2022

ghost Jan 19, 2022

cocreature Jan 19, 2022

ghost commented Jan 19, 2022

	isSupported = features => features.contractIds.v0.isSupported,
	isSupported = features => false,

ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] #12454

ledger-api-test-tool: Govern ContractIdIT test runs through a feature. [KVL-1261] #12454

Conversation

ghost commented Jan 18, 2022 • edited by ghost Loading

Changelog

Pull Request Checklist

fabiotudone-da left a comment

Choose a reason for hiding this comment

meiersi-da Jan 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remyhaemmerle-da Jan 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remyhaemmerle-da Jan 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remyhaemmerle-da left a comment

Choose a reason for hiding this comment

cocreature left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remyhaemmerle-da Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jan 19, 2022

ghost commented Jan 18, 2022 •

edited by ghost

Loading

meiersi-da Jan 18, 2022 •

edited

Loading

remyhaemmerle-da Jan 18, 2022 •

edited

Loading

remyhaemmerle-da Jan 18, 2022 •

edited

Loading

remyhaemmerle-da Jan 19, 2022 •

edited

Loading