Skip to content

Commit

Permalink
ledger-api-test-tool: Remove retired tests. (#12535)
Browse files Browse the repository at this point in the history
CHANGELOG_BEGIN
- [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT``
  and ``TransactionScaleIT``, have been removed in favor of more
  targeted benchmarking tests. If you are actively including these tests
  in your test run, you will need to remove them. These tests are
  disabled by default so it is likely that no change will be needed.
CHANGELOG_END
  • Loading branch information
SamirTalwar authored Jan 21, 2022
1 parent cbb4986 commit 7218e6f
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 75 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ object LedgerApiTestTool {
)
val optionalTests: Vector[LedgerTestSuite] = Tests.optional()
val visibleTests: Vector[LedgerTestSuite] = defaultTests ++ optionalTests
val allTests: Vector[LedgerTestSuite] = visibleTests ++ Tests.retired
val allTests: Vector[LedgerTestSuite] = visibleTests
val allTestCaseNames: Set[String] = allTests.flatMap(_.tests).map(_.name).toSet
val missingTests = (config.included ++ config.excluded).filterNot(prefix =>
allTestCaseNames.exists(_.startsWith(prefix))
Expand Down Expand Up @@ -149,7 +149,7 @@ object LedgerApiTestTool {
})

val defaultCases = defaultTests.flatMap(_.tests)
val allCases = defaultCases ++ optionalTests.flatMap(_.tests) ++ Tests.retired.flatMap(_.tests)
val allCases = defaultCases ++ optionalTests.flatMap(_.tests)

val includedTests =
if (config.included.isEmpty) defaultCases
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ object Tests {
new TLSAtLeastOnePointTwoIT,
)

val retired: Vector[LedgerTestSuite] =
Vector(
new LotsOfPartiesIT,
new TransactionScaleIT,
)

/** These are performance envelope tests that also provide benchmarks and are always run
* sequentially; they also must be specified explicitly with --perf-tests and will exclude
* all other tests.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class NamesSpec extends AnyWordSpec with Matchers {
}

object NamesSpec {
private val allTestSuites = Tests.default() ++ Tests.optional() ++ Tests.retired
private val allTestSuites = Tests.default() ++ Tests.optional()
private val allTestSuiteNames = allTestSuites.map(_.name).sorted

private val allTests = allTestSuites.flatMap(_.tests)
Expand Down

0 comments on commit 7218e6f

Please sign in to comment.