Cache type synonym expansion in safeToReexport #11612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really significant but seems better to be on the safe side and keep this consistent with isDuplicate than try to do something different here. changelog_begin changelog_end
cocreature
force-pushed
the
cache-safetoreexport
branch
from
0c82e0e to
4f99330
Compare
sofiafaro-da
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Looks good, thank you!
I was very confused by this PR. I didn't realize we were doing this sort of comparison for both synonyms and instances. I thought it was only for synonyms. I see why we're doing it in both case, though I'm not sure this is the correct approach for instances. But this PR isn't changing the approach, just making it faster, so it's definitely worth approving.
yeah I agree it’s a bit iffy. For now, I’m only trying to make things faster but I’m very open to change the approach as well. |
azure-pipelines bot
pushed a commit
that referenced
this pull request
Nov 10, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @remyhaemmerle-da is in charge of this release. Commit log: ``` 9218116 LF: Abstract VersionedValue and VersionedContractInstance (#11533) b87acab foldLeft, foldRight, other Foldable specializations (#11592) 92dfcde [Self-service error codes] Use error validators in ApiPackageManagementService (#11575) 6372d41 limit contract insertion/deletion batching on backpressure (#11589) 3588284 Fix screenshots in daml intro 2 (#11617) ef3fc0e Cache type synonym expansion in safeToReexport (#11612) 70b2fe3 Provide byInterface fields for fetch, exercise. (#11607) 830779f LF: drop useless class com.daml.lf.transaction (#11601) 7c92cab Cache type synonym expansion in isDuplicate (#11611) cfd521f Fix GHC build errors on macOS (#11560) a7559d0 LF: Rename GenTransaction to Transaction (#11599) 3b61a1b LF: allow exercise command by template for inherited choice. (#11584) af1bee7 precondition lf conversion (#11538) f722cf1 Bump extractor init timeout to 60s (#11598) 1e0a221 Set symlink_node_modules = False (#11606) ac19c8c Synchronize in multi-participant script tests (#11594) dd1b034 Restart the submission interpretation in case of a race [DPP-737] (#11579) 8d2b1b9 [JSON-API] Port of http-perf-test to sandbox(aka next) (#11543) 56a6db8 codeowners: reflect change in onwership of meiersi-da (#11505) d433651 fix a few typos in Daml-LF spec (#11583) 5dee88b Refactoring store factories [DPP-709] (#11572) 41fb289 Port LedgerApiServer rate limiter interface from canton (#11577) 04cc5d7 Mark JSON API integration tests as flaky (#11586) 3bed7a9 Drop unused defaultFeatureFlags (#11580) cbc3c8c Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) 7d68e05 Remove virtual choices (#11482) 9b94fa9 [ledger-api] - metadata for invalid deduplication period [KVL-1170] (#11534) e7eb60f update compat versions for 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11531) a3d04ca Migrate matches-docs tests to sandbox on postgres (#11573) 21c9745 [Self-service error codes] ValueSwitch parameterized method (#11567) 6a0b84e Run Script export tests against BR (#11574) a3195fd fix link to blog (#11570) 0823601 Self-service errors: generate error deprecation docs [KVL-1187] (#11539) 8d48cf6 DPP-664 Create contracts in batches (#11515) 9ef2eaf Remove parameter table join from SQL queries [DPP-705] (#11562) af7f7f3 Fix LF coedowners (#11563) 4450311 Exclude/fix compatibility tests (#11529) 699c28f rotate release duty after 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11522) 4d4869f interfaces: Improve fixed choice lookup (#11551) ba96bf7 Add DbDtoToStringsForInterning [DPP-708] (#11557) 692dac6 LF: deprecate remaining type alias in Transaction (#11554) 7bc0f82 [kvutils] - Extract command deduplication steps from the TransactionCommitter [KVL-1174] (#11547) 0e95ccb Wire LedgerEndCache to relevant StorageBackend factories [DPP-704] (#11549) 73cb42e LF: deprecate ensureNoCid and assertNoCid in CidContainer (#11502) 30bfee9 Upgrade canton for conformance tests (#11550) b84a914 Extractor: replace `sandbox-classic`-based fixtures with `sandbox`-based ones (#11489) d86fe92 ledger-api-bench-tool - flexible stream filters [DPP-667] (#11458) 214c7ab Self-service errors: generate groups documentation [KVL-1186] (#11526) 60dc286 Avoid unnecessarily decoding DALFs during dependency installation (#11541) afd79b6 Improve logging for dependency installation (#11540) fdde535 fix hoogle by pinning nixpkgs (#11548) 5e93df6 Full conformance test with self-service error codes on ledger-on-memory (#11524) efaf20b update NOTICES file (#11546) c7bb94b Modify contract key attribute age for createAndExercise to avoid contract key violation on slow running tests (#11530) 541d07c Add string-interning data access [DPP-707] (#11484) 6c94164 Switching to composition at StorageBackend [DPP-704] (#11520) d006ad0 Add string-interning view primitives [DPP-702] (#11475) a917520 Save the submission time in the command deduplication value [KVL-1173] (#11509) 669186f Add priority-queue based worker Source [DPP-717] (#11500) 2091f59 Remove cats from kvutils (#11537) b83af37 Fix recache log statement (#11536) 776790e Add choice collisions in scala name collision checker (#11528) 2efcb21 Extract the setting of the time bounds on the commit context [KVL-1173] (#11516) 9bb1d64 [ledger-api] - Return FAILED_PRECONDITION gRPC status code for invalid deduplication duration [KVL-1170] (#11483) c098d75 Add a --log-level flag to damlc (#11514) afee948 Bump rules_nixpkgs (#11517) d6fb67c release 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11521) ac49d69 Ensure that -Werror converts parser warnings into errors (#11511) bda35ca ledger-offset: Add a conversion to ByteString. (#11491) 8a9f15b [DPP-686][Self-service error codes] Removing default error factories (#11403) bb37eef Switch script & trigger tests to postgres-backed Sadbonx (#11525) ``` Changelog: ``` - [JSON API] While updating the contract table for a query, if the DB appears to be slow, JSON API will slow down its own inserts and deletes at some point rather than construct ever-larger INSERT and DELETE batch commands. See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__. [Ledger API] Retry the interpretation of a command in case of a race with other transactions. This fix drastically reduces the likelihood of the error "Could not find a suitable ledger time after 0 retries". [ledger-api] - Return max_deduplication_duration as part of the metadata sent with the gRPC status for commands rejected because of invalid deduplication periods - [Integration Kit] - ledger-api-bench-tool - added flexible party and template filters for transactions, transaction trees and active contract streams [ledger-api] - Return FAILED_PRECONDITION gRPC status code, instead of INVALID_ARGUMENT, for an invalid command deduplication duration ``` CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
pushed a commit
that referenced
this pull request
Nov 10, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @remyhaemmerle-da is in charge of this release. Commit log: ``` 9218116 LF: Abstract VersionedValue and VersionedContractInstance (#11533) b87acab foldLeft, foldRight, other Foldable specializations (#11592) 92dfcde [Self-service error codes] Use error validators in ApiPackageManagementService (#11575) 6372d41 limit contract insertion/deletion batching on backpressure (#11589) 3588284 Fix screenshots in daml intro 2 (#11617) ef3fc0e Cache type synonym expansion in safeToReexport (#11612) 70b2fe3 Provide byInterface fields for fetch, exercise. (#11607) 830779f LF: drop useless class com.daml.lf.transaction (#11601) 7c92cab Cache type synonym expansion in isDuplicate (#11611) cfd521f Fix GHC build errors on macOS (#11560) a7559d0 LF: Rename GenTransaction to Transaction (#11599) 3b61a1b LF: allow exercise command by template for inherited choice. (#11584) af1bee7 precondition lf conversion (#11538) f722cf1 Bump extractor init timeout to 60s (#11598) 1e0a221 Set symlink_node_modules = False (#11606) ac19c8c Synchronize in multi-participant script tests (#11594) dd1b034 Restart the submission interpretation in case of a race [DPP-737] (#11579) 8d2b1b9 [JSON-API] Port of http-perf-test to sandbox(aka next) (#11543) 56a6db8 codeowners: reflect change in onwership of meiersi-da (#11505) d433651 fix a few typos in Daml-LF spec (#11583) 5dee88b Refactoring store factories [DPP-709] (#11572) 41fb289 Port LedgerApiServer rate limiter interface from canton (#11577) 04cc5d7 Mark JSON API integration tests as flaky (#11586) 3bed7a9 Drop unused defaultFeatureFlags (#11580) cbc3c8c Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) 7d68e05 Remove virtual choices (#11482) 9b94fa9 [ledger-api] - metadata for invalid deduplication period [KVL-1170] (#11534) e7eb60f update compat versions for 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11531) a3d04ca Migrate matches-docs tests to sandbox on postgres (#11573) 21c9745 [Self-service error codes] ValueSwitch parameterized method (#11567) 6a0b84e Run Script export tests against BR (#11574) a3195fd fix link to blog (#11570) 0823601 Self-service errors: generate error deprecation docs [KVL-1187] (#11539) 8d48cf6 DPP-664 Create contracts in batches (#11515) 9ef2eaf Remove parameter table join from SQL queries [DPP-705] (#11562) af7f7f3 Fix LF coedowners (#11563) 4450311 Exclude/fix compatibility tests (#11529) 699c28f rotate release duty after 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11522) 4d4869f interfaces: Improve fixed choice lookup (#11551) ba96bf7 Add DbDtoToStringsForInterning [DPP-708] (#11557) 692dac6 LF: deprecate remaining type alias in Transaction (#11554) 7bc0f82 [kvutils] - Extract command deduplication steps from the TransactionCommitter [KVL-1174] (#11547) 0e95ccb Wire LedgerEndCache to relevant StorageBackend factories [DPP-704] (#11549) 73cb42e LF: deprecate ensureNoCid and assertNoCid in CidContainer (#11502) 30bfee9 Upgrade canton for conformance tests (#11550) b84a914 Extractor: replace `sandbox-classic`-based fixtures with `sandbox`-based ones (#11489) d86fe92 ledger-api-bench-tool - flexible stream filters [DPP-667] (#11458) 214c7ab Self-service errors: generate groups documentation [KVL-1186] (#11526) 60dc286 Avoid unnecessarily decoding DALFs during dependency installation (#11541) afd79b6 Improve logging for dependency installation (#11540) fdde535 fix hoogle by pinning nixpkgs (#11548) 5e93df6 Full conformance test with self-service error codes on ledger-on-memory (#11524) efaf20b update NOTICES file (#11546) c7bb94b Modify contract key attribute age for createAndExercise to avoid contract key violation on slow running tests (#11530) 541d07c Add string-interning data access [DPP-707] (#11484) 6c94164 Switching to composition at StorageBackend [DPP-704] (#11520) d006ad0 Add string-interning view primitives [DPP-702] (#11475) a917520 Save the submission time in the command deduplication value [KVL-1173] (#11509) 669186f Add priority-queue based worker Source [DPP-717] (#11500) 2091f59 Remove cats from kvutils (#11537) b83af37 Fix recache log statement (#11536) 776790e Add choice collisions in scala name collision checker (#11528) 2efcb21 Extract the setting of the time bounds on the commit context [KVL-1173] (#11516) 9bb1d64 [ledger-api] - Return FAILED_PRECONDITION gRPC status code for invalid deduplication duration [KVL-1170] (#11483) c098d75 Add a --log-level flag to damlc (#11514) afee948 Bump rules_nixpkgs (#11517) d6fb67c release 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11521) ac49d69 Ensure that -Werror converts parser warnings into errors (#11511) bda35ca ledger-offset: Add a conversion to ByteString. (#11491) 8a9f15b [DPP-686][Self-service error codes] Removing default error factories (#11403) bb37eef Switch script & trigger tests to postgres-backed Sadbonx (#11525) ``` Changelog: ``` - [JSON API] While updating the contract table for a query, if the DB appears to be slow, JSON API will slow down its own inserts and deletes at some point rather than construct ever-larger INSERT and DELETE batch commands. See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__. [Ledger API] Retry the interpretation of a command in case of a race with other transactions. This fix drastically reduces the likelihood of the error "Could not find a suitable ledger time after 0 retries". [ledger-api] - Return max_deduplication_duration as part of the metadata sent with the gRPC status for commands rejected because of invalid deduplication periods - [Integration Kit] - ledger-api-bench-tool - added flexible party and template filters for transactions, transaction trees and active contract streams [ledger-api] - Return FAILED_PRECONDITION gRPC status code, instead of INVALID_ARGUMENT, for an invalid command deduplication duration ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines Daml Build <[email protected]>
stefanobaghino-da
added a commit
that referenced
this pull request
Nov 11, 2021
changelog_begin changelog_end CHANGELOG ENTRIES ``` [TS-Bindings] Ws multiplexing for stream queries is disabled by default as we investigate issues of intermittent websocket closures. * There is now an Early Access Helm chart to start all of the Connect components on a Kubernetes cluster. [JSON-API] Make certain Hikari cp connection pool properties configurable via jdbc conf string, the properties are listed below poolSize -- specifies the max pool size for the database connection pool minIdle -- specifies the min idle connections for database connection pool connectionTimeout -- long value, specifies the connection timeout for database connection pool idleTimeout -- long value, specifies the idle timeout for the database connection pool - [Integration Kit] - ledger-api-bench-tool can run a workflow consisting of the command submission phase and stream benchmark phase. - [JSON API] While updating the contract table for a query, if the DB appears to be slow, JSON API will slow down its own inserts and deletes at some point rather than construct ever-larger INSERT and DELETE batch commands. See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__. [Ledger API] Retry the interpretation of a command in case of a race with other transactions. This fix drastically reduces the likelihood of the error "Could not find a suitable ledger time after 0 retries". [ledger-api] - Return max_deduplication_duration as part of the metadata sent with the gRPC status for commands rejected because of invalid deduplication periods - [Integration Kit] - ledger-api-bench-tool - added flexible party and template filters for transactions, transaction trees and active contract streams ``` COMMITS ``` d938a44 ws multiplexing is disabled by default as we investigate issues with intermittent web socket closures (#11657) 0f0a865 Make string interning available at ingestion [DPP-711] (#11645) 7296ba4 Move closureConvert and validate compiler phases into separate files. (#11656) 87f282c interfaces: Preserve/provide by_interface data for create actions. (#11639) a9de728 Update rules_scala (#11616) f468969 document helm chart (#11648) 55d4a03 Release 1.11.3 snapshot (#11652) 2dd5289 different types for different speedy phases (#11605) 44d604d Release new 1.18 snapshot (#11642) e69a871 [JSON-API] Configurable Hikari connection pool props (#11621) cb7099b release 1.11.3 snapshot (#11628) fd61d0b String interning read integration [DPP-706] (#11638) c5a1f0b Republish error codes generator lib (#11633) a6f745f Add two phase retrieval merge function [DPP-718] (#11571) 743ee46 ledger-api-bench-tool - command submission and stream reading complete workflow [DPP-668] (#11544) f8f8807 Activate interning write side [DPP-710] (#11614) 93c07f4 Extend synonym expansion caching in data-dependencies (#11629) cf445b2 Skip platform independence tests on release PRs (#11631) b8f384e LF: Drop typeparameter from KeyWithMaintainers (#11625) d0c313d Share dependencyInfo in data-dependencies (#11620) 4eed1d9 release 1.18.0-snapshot.20211109.8328.0.92181161 (#11623) 9218116 LF: Abstract VersionedValue and VersionedContractInstance (#11533) b87acab foldLeft, foldRight, other Foldable specializations (#11592) 92dfcde [Self-service error codes] Use error validators in ApiPackageManagementService (#11575) 6372d41 limit contract insertion/deletion batching on backpressure (#11589) 3588284 Fix screenshots in daml intro 2 (#11617) ef3fc0e Cache type synonym expansion in safeToReexport (#11612) 70b2fe3 Provide byInterface fields for fetch, exercise. (#11607) 830779f LF: drop useless class com.daml.lf.transaction (#11601) 7c92cab Cache type synonym expansion in isDuplicate (#11611) cfd521f Fix GHC build errors on macOS (#11560) a7559d0 LF: Rename GenTransaction to Transaction (#11599) 3b61a1b LF: allow exercise command by template for inherited choice. (#11584) af1bee7 precondition lf conversion (#11538) f722cf1 Bump extractor init timeout to 60s (#11598) 1e0a221 Set symlink_node_modules = False (#11606) ac19c8c Synchronize in multi-participant script tests (#11594) dd1b034 Restart the submission interpretation in case of a race [DPP-737] (#11579) 8d2b1b9 [JSON-API] Port of http-perf-test to sandbox(aka next) (#11543) 56a6db8 codeowners: reflect change in onwership of meiersi-da (#11505) d433651 fix a few typos in Daml-LF spec (#11583) 5dee88b Refactoring store factories [DPP-709] (#11572) 41fb289 Port LedgerApiServer rate limiter interface from canton (#11577) 04cc5d7 Mark JSON API integration tests as flaky (#11586) 3bed7a9 Drop unused defaultFeatureFlags (#11580) cbc3c8c Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) 7d68e05 Remove virtual choices (#11482) 9b94fa9 [ledger-api] - metadata for invalid deduplication period [KVL-1170] (#11534) e7eb60f update compat versions for 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11531) a3d04ca Migrate matches-docs tests to sandbox on postgres (#11573) 21c9745 [Self-service error codes] ValueSwitch parameterized method (#11567) 6a0b84e Run Script export tests against BR (#11574) a3195fd fix link to blog (#11570) 0823601 Self-service errors: generate error deprecation docs [KVL-1187] (#11539) 8d48cf6 DPP-664 Create contracts in batches (#11515) 9ef2eaf Remove parameter table join from SQL queries [DPP-705] (#11562) af7f7f3 Fix LF coedowners (#11563) 4450311 Exclude/fix compatibility tests (#11529) 699c28f rotate release duty after 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11522) 4d4869f interfaces: Improve fixed choice lookup (#11551) ba96bf7 Add DbDtoToStringsForInterning [DPP-708] (#11557) 692dac6 LF: deprecate remaining type alias in Transaction (#11554) 7bc0f82 [kvutils] - Extract command deduplication steps from the TransactionCommitter [KVL-1174] (#11547) 0e95ccb Wire LedgerEndCache to relevant StorageBackend factories [DPP-704] (#11549) 73cb42e LF: deprecate ensureNoCid and assertNoCid in CidContainer (#11502) 30bfee9 Upgrade canton for conformance tests (#11550) b84a914 Extractor: replace `sandbox-classic`-based fixtures with `sandbox`-based ones (#11489) d86fe92 ledger-api-bench-tool - flexible stream filters [DPP-667] (#11458) 214c7ab Self-service errors: generate groups documentation [KVL-1186] (#11526) 60dc286 Avoid unnecessarily decoding DALFs during dependency installation (#11541) afd79b6 Improve logging for dependency installation (#11540) fdde535 fix hoogle by pinning nixpkgs (#11548) 5e93df6 Full conformance test with self-service error codes on ledger-on-memory (#11524) efaf20b update NOTICES file (#11546) c7bb94b Modify contract key attribute age for createAndExercise to avoid contract key violation on slow running tests (#11530) 541d07c Add string-interning data access [DPP-707] (#11484) 6c94164 Switching to composition at StorageBackend [DPP-704] (#11520) d006ad0 Add string-interning view primitives [DPP-702] (#11475) a917520 Save the submission time in the command deduplication value [KVL-1173] (#11509) 669186f Add priority-queue based worker Source [DPP-717] (#11500) 2091f59 Remove cats from kvutils (#11537) b83af37 Fix recache log statement (#11536) 776790e Add choice collisions in scala name collision checker (#11528) 2efcb21 Extract the setting of the time bounds on the commit context [KVL-1173] (#11516) 9bb1d64 [ledger-api] - Return FAILED_PRECONDITION gRPC status code for invalid deduplication duration [KVL-1170] (#11483) c098d75 Add a --log-level flag to damlc (#11514) afee948 Bump rules_nixpkgs (#11517) d6fb67c release 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11521) ac49d69 Ensure that -Werror converts parser warnings into errors (#11511) bda35ca ledger-offset: Add a conversion to ByteString. (#11491) 8a9f15b [DPP-686][Self-service error codes] Removing default error factories (#11403) bb37eef Switch script & trigger tests to postgres-backed Sadbonx (#11525) ``` Since `v1.18.0-snapshot.20211102.8257.0.7391a3cd`
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2021
changelog_begin changelog_end CHANGELOG ENTRIES ``` [TS-Bindings] Ws multiplexing for stream queries is disabled by default as we investigate issues of intermittent websocket closures. * There is now an Early Access Helm chart to start all of the Connect components on a Kubernetes cluster. [JSON-API] Make certain Hikari cp connection pool properties configurable via jdbc conf string, the properties are listed below poolSize -- specifies the max pool size for the database connection pool minIdle -- specifies the min idle connections for database connection pool connectionTimeout -- long value, specifies the connection timeout for database connection pool idleTimeout -- long value, specifies the idle timeout for the database connection pool - [Integration Kit] - ledger-api-bench-tool can run a workflow consisting of the command submission phase and stream benchmark phase. - [JSON API] While updating the contract table for a query, if the DB appears to be slow, JSON API will slow down its own inserts and deletes at some point rather than construct ever-larger INSERT and DELETE batch commands. See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__. [Ledger API] Retry the interpretation of a command in case of a race with other transactions. This fix drastically reduces the likelihood of the error "Could not find a suitable ledger time after 0 retries". [ledger-api] - Return max_deduplication_duration as part of the metadata sent with the gRPC status for commands rejected because of invalid deduplication periods - [Integration Kit] - ledger-api-bench-tool - added flexible party and template filters for transactions, transaction trees and active contract streams ``` COMMITS ``` d938a44 ws multiplexing is disabled by default as we investigate issues with intermittent web socket closures (#11657) 0f0a865 Make string interning available at ingestion [DPP-711] (#11645) 7296ba4 Move closureConvert and validate compiler phases into separate files. (#11656) 87f282c interfaces: Preserve/provide by_interface data for create actions. (#11639) a9de728 Update rules_scala (#11616) f468969 document helm chart (#11648) 55d4a03 Release 1.11.3 snapshot (#11652) 2dd5289 different types for different speedy phases (#11605) 44d604d Release new 1.18 snapshot (#11642) e69a871 [JSON-API] Configurable Hikari connection pool props (#11621) cb7099b release 1.11.3 snapshot (#11628) fd61d0b String interning read integration [DPP-706] (#11638) c5a1f0b Republish error codes generator lib (#11633) a6f745f Add two phase retrieval merge function [DPP-718] (#11571) 743ee46 ledger-api-bench-tool - command submission and stream reading complete workflow [DPP-668] (#11544) f8f8807 Activate interning write side [DPP-710] (#11614) 93c07f4 Extend synonym expansion caching in data-dependencies (#11629) cf445b2 Skip platform independence tests on release PRs (#11631) b8f384e LF: Drop typeparameter from KeyWithMaintainers (#11625) d0c313d Share dependencyInfo in data-dependencies (#11620) 4eed1d9 release 1.18.0-snapshot.20211109.8328.0.92181161 (#11623) 9218116 LF: Abstract VersionedValue and VersionedContractInstance (#11533) b87acab foldLeft, foldRight, other Foldable specializations (#11592) 92dfcde [Self-service error codes] Use error validators in ApiPackageManagementService (#11575) 6372d41 limit contract insertion/deletion batching on backpressure (#11589) 3588284 Fix screenshots in daml intro 2 (#11617) ef3fc0e Cache type synonym expansion in safeToReexport (#11612) 70b2fe3 Provide byInterface fields for fetch, exercise. (#11607) 830779f LF: drop useless class com.daml.lf.transaction (#11601) 7c92cab Cache type synonym expansion in isDuplicate (#11611) cfd521f Fix GHC build errors on macOS (#11560) a7559d0 LF: Rename GenTransaction to Transaction (#11599) 3b61a1b LF: allow exercise command by template for inherited choice. (#11584) af1bee7 precondition lf conversion (#11538) f722cf1 Bump extractor init timeout to 60s (#11598) 1e0a221 Set symlink_node_modules = False (#11606) ac19c8c Synchronize in multi-participant script tests (#11594) dd1b034 Restart the submission interpretation in case of a race [DPP-737] (#11579) 8d2b1b9 [JSON-API] Port of http-perf-test to sandbox(aka next) (#11543) 56a6db8 codeowners: reflect change in onwership of meiersi-da (#11505) d433651 fix a few typos in Daml-LF spec (#11583) 5dee88b Refactoring store factories [DPP-709] (#11572) 41fb289 Port LedgerApiServer rate limiter interface from canton (#11577) 04cc5d7 Mark JSON API integration tests as flaky (#11586) 3bed7a9 Drop unused defaultFeatureFlags (#11580) cbc3c8c Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576) 7d68e05 Remove virtual choices (#11482) 9b94fa9 [ledger-api] - metadata for invalid deduplication period [KVL-1170] (#11534) e7eb60f update compat versions for 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11531) a3d04ca Migrate matches-docs tests to sandbox on postgres (#11573) 21c9745 [Self-service error codes] ValueSwitch parameterized method (#11567) 6a0b84e Run Script export tests against BR (#11574) a3195fd fix link to blog (#11570) 0823601 Self-service errors: generate error deprecation docs [KVL-1187] (#11539) 8d48cf6 DPP-664 Create contracts in batches (#11515) 9ef2eaf Remove parameter table join from SQL queries [DPP-705] (#11562) af7f7f3 Fix LF coedowners (#11563) 4450311 Exclude/fix compatibility tests (#11529) 699c28f rotate release duty after 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11522) 4d4869f interfaces: Improve fixed choice lookup (#11551) ba96bf7 Add DbDtoToStringsForInterning [DPP-708] (#11557) 692dac6 LF: deprecate remaining type alias in Transaction (#11554) 7bc0f82 [kvutils] - Extract command deduplication steps from the TransactionCommitter [KVL-1174] (#11547) 0e95ccb Wire LedgerEndCache to relevant StorageBackend factories [DPP-704] (#11549) 73cb42e LF: deprecate ensureNoCid and assertNoCid in CidContainer (#11502) 30bfee9 Upgrade canton for conformance tests (#11550) b84a914 Extractor: replace `sandbox-classic`-based fixtures with `sandbox`-based ones (#11489) d86fe92 ledger-api-bench-tool - flexible stream filters [DPP-667] (#11458) 214c7ab Self-service errors: generate groups documentation [KVL-1186] (#11526) 60dc286 Avoid unnecessarily decoding DALFs during dependency installation (#11541) afd79b6 Improve logging for dependency installation (#11540) fdde535 fix hoogle by pinning nixpkgs (#11548) 5e93df6 Full conformance test with self-service error codes on ledger-on-memory (#11524) efaf20b update NOTICES file (#11546) c7bb94b Modify contract key attribute age for createAndExercise to avoid contract key violation on slow running tests (#11530) 541d07c Add string-interning data access [DPP-707] (#11484) 6c94164 Switching to composition at StorageBackend [DPP-704] (#11520) d006ad0 Add string-interning view primitives [DPP-702] (#11475) a917520 Save the submission time in the command deduplication value [KVL-1173] (#11509) 669186f Add priority-queue based worker Source [DPP-717] (#11500) 2091f59 Remove cats from kvutils (#11537) b83af37 Fix recache log statement (#11536) 776790e Add choice collisions in scala name collision checker (#11528) 2efcb21 Extract the setting of the time bounds on the commit context [KVL-1173] (#11516) 9bb1d64 [ledger-api] - Return FAILED_PRECONDITION gRPC status code for invalid deduplication duration [KVL-1170] (#11483) c098d75 Add a --log-level flag to damlc (#11514) afee948 Bump rules_nixpkgs (#11517) d6fb67c release 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11521) ac49d69 Ensure that -Werror converts parser warnings into errors (#11511) bda35ca ledger-offset: Add a conversion to ByteString. (#11491) 8a9f15b [DPP-686][Self-service error codes] Removing default error factories (#11403) bb37eef Switch script & trigger tests to postgres-backed Sadbonx (#11525) ``` Since `v1.18.0-snapshot.20211102.8257.0.7391a3cd`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really significant but seems better to be on the safe side and
keep this consistent with isDuplicate than try to do something
different here.
Needs rebasing on #11611 once that is merged.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.