HA PoC behind a feature flag [DPP-426] #10227

nmarton-da · 2021-07-09T07:38:28Z

changelog_begin
changelog_end

Pull Request Checklist

Read and understand the contribution guidelines
Include appropriate tests
Set a descriptive title and thorough description
Add a reference to the issue this PR will solve, if appropriate
Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

meiersi-da

Good stuff @nmarton-da ! Some small comments, but nothing major.

ledger/participant-integration-api/BUILD.bazel

ledger/participant-integration-api/src/main/scala/platform/indexer/IndexerConfig.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/JdbcIndexer.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/HaCoordinator.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala

ledger/participant-integration-api/src/main/scala/platform/store/backend/StorageBackend.scala

...t-integration-api/src/main/scala/platform/store/backend/common/InitHookDataSourceProxy.scala

...pant-integration-api/src/main/scala/platform/store/backend/oracle/OracleStorageBackend.scala

libs-scala/oracle-testing/src/main/scala/testing/oracle/OracleAround.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala

ledger/participant-integration-api/src/main/scala/platform/store/backend/StorageBackend.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/KillSwitchCaptor.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PollingChecker.scala

...t-integration-api/src/main/scala/platform/store/backend/common/InitHookDataSourceProxy.scala

...r/participant-integration-api/src/main/scala/platform/store/appendonlydao/DbDispatcher.scala

...cipant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala

meiersi-da

Only cosmetic changes. Feel free to postpone.

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/HaCoordinator.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PollingChecker.scala

...pant-integration-api/src/main/scala/platform/store/backend/oracle/OracleStorageBackend.scala

...cipant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala

...-state/kvutils/app/src/main/scala/com/daml/ledger/participant/state/kvutils/app/Config.scala

rautenrieth-da

I have reviewed the first few commits in detail. I have not found any issue with the changed implementation of connection acquisition and async commit handling (but we should also rely on tests because this refactoring is hard to review).

...ntegration-api/src/main/scala/platform/store/backend/postgresql/PostgresStorageBackend.scala

ledger/participant-integration-api/src/main/scala/platform/store/backend/StorageBackend.scala

...t-integration-api/src/main/scala/platform/store/backend/common/InitHookDataSourceProxy.scala

...tegration-api/src/main/scala/platform/store/appendonlydao/HikariJdbcConnectionProvider.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/HaCoordinator.scala

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala

tudor-da · 2021-07-20T11:43:14Z

...cipant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala

@@ -108,12 +127,11 @@ object ParallelIndexerFactory {
                .map(_ -> System.nanoTime())
            )
              .map(_ => ())
-              .keepAlive(
+              .keepAlive( // TODO ha: remove as stable. This keepAlive approach was introduced for safety with async commit. This is still needed until HA is mandatory for Postgres to ensure safety with async commit.


What removes the need of this keepAlive here? is it the PollingChecker from the HaCoordinator?
If yes, it might be good to mention it here

The keepAlive's main purpose here is to let the indexing die if connectivity to DB is lost, to prevent the corner case scenario with async commit, and unnoticed DB restarts.
With postgres+async commit+ha DB restarts cannot go unnoticed, because if the main connection (which holds the main indexer lock) breaks, we loose the indexer lock, and shut down indexing as soon as detected.
(Also we cannot initialize an additional connection to database, if we cannot verify that the main connection still holds the lock.)
I'll make a note about this in the TODO

tudor-da

LGTM. Left two minor comments regarding logging and comments

Previous async commit features had - async commit configured by conifg-param - special treatments to stil force sync commit for certain threadpools - special treatment to stil force sync commit on transaction level for certain transactions. This is a preparation step to clean the path for adding a new approach for async commit treatment: - only session/connection level async configuration - no transaction level special treatments - only enable async commit for specific Connection pools (where it is needed / is safe) See next commits changelog_begin changelog_end

- to spawn DataSources in a controlled fashion these will be needed in upcoming commits for the HikariCP - DataSources can have Connection init hooks defined with the help of the InitHookDataSourceProxy (this is needed for HA implementation) - added DataSourceConfig to capture needed level of fine-tuning for DataSource creation changelog_begin changelog_end

changelog_begin changelog_end

- this is the abstraction and the implementation of database level locking - with support for Oracle and Postgres changelog_begin changelog_end

- this is the core implementation of the Participant HA feature changelog_begin changelog_end

changelog_begin changelog_end

* Pulling out and fixing concurrency issue with KillSwitchCaptor * Fixing typos, doc * Renames * Fixes logging changelog_begin changelog_end

changelog_begin changelog_end

* Adds feature flag * Removes TODOs * Removes extra logging * Remove main-connection-lost simulation changelog_begin changelog_end

changelog_begin changelog_end

We need this extra level of safety until HA is behind feature flag We can remove this part as soon as HA is mandatory, since HA coordination takes care of this aspect implicitly, and more precisely (aspect: detecting loss of connection to db) changelog_begin changelog_end

* Increase log level for a potentially transient log message * Adds logging to the second getConnection method in InitHookDataSourceProxy * Rename changelog_begin changelog_end

As suggested in the design document changelog_begin changelog_end

* Wording changes * Unwrapping a single abstract method for clarity * Comment changes * Logging changes * Changes the name of the feature flag changelog_begin changelog_end

As discussed in the PR, the note is not needed by now. changelog_begin changelog_end

* removing jdbcUrl from HikariDataSourceOwner * comment changes * renames * re-adding an override * removing some parsing logic from PgSynchronousCommitValue changelog_begin changelog_end

…lementation related configurations changelog_begin changelog_end

changelog_begin changelog_end

@remyhaemmerle-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @remyhaemmerle-da is in charge of this release. Commit log: ``` b5e9d86 Moved DamlSubmission* into separate proto file [KVL-980] (#10362) 0da814d Let stable packages bypass LF version restrictions. (#10377) c97cbca [JSON-API] Validate schema version & add minimal options for schema creation (#10374) ebb8fab Add a ContractDao benchmark for payload queries (#10426) 85af078 LF: parser for LF versions (#10424) b976c9c Disable autocommit for hikariCP for http-json-api db conn (#10427) 3ca46a4 Removed unused import. (#10425) 4d12493 Introduce buf checks [KVL-980] (#10411) 1c4ae50 Revert "Upgrade hikari to latest jdk8 version (#10406)" (#10421) fe1b642 Don't fail if logs directory exists already (#10423) 7c88b56 participant-integration-api: Fix completion debug log output. (#10415) fc305e6 [JSON-API] Shutdown on startup if the db connection is invalid (#10360) 6db5869 Update vcredist (#10417) 4b55f1a Connection pool for Contract Dao (#10359) 72cf2f3 LF: replace bazel keyword stable by default (#10410) 2bdcb7b update NOTICES file (#10414) 39c6e0b Fix oracle message too long error (#10413) 2094e24 Indexer ValidateAndWaitOnly startup mode for canton participant HA (#10290) ad13a86 Windows dev-env Powershell 7 compatibility (#10408) 3cedd83 Easy to parse ledger-api-bench-tool logs (#10320) 16ff20c Fix links in changelog (#10409) b325e8a participant-state: Remove `WriteService#rejectSubmission`. (#10407) 9be520c Keep the participant-state API prefixed. [KVL-1002] (#10405) d88dc71 Upgrade hikari to latest jdk8 version (#10406) 8b337bd Publish ledger-indexer-benchmark (#10401) 9e05f38 ledger-api-domain: Store the deduplication duration in `Commands`. [KVL-1002] (#10403) 9c064da Allow imports of internal modules (#10397) b9518ce participant-state-metrics: Add wrappers for v2. (#10404) c3a3d60 don't call Gary, he's on holiday (#10400) 221d0a0 use doobie 0.9.0 Fragment-in-Fragment interpolation in json-api db-backend (#10399) 17709b5 use a single SQL query for any number of json-api query pairs (#10344) 6a16684 Stop publishing the db-backend artifact (#10396) 1bed05f Treat KeyWithMaintainers field structurally in all node types. (#10392) d7077e1 Introduce locally-defined `Rejection` reasons instead of the participant-state rejection reason type. [KVL-1002] (#10376) 96f0483 [Divulgence pruning] Conformance tests implementation [DPP-484] (#10385) 28c5e9a update NOTICES file (#10386) 3879452 fix cut&paste typo bug; there are no insig lookup tweaks! (#10389) 7df9758 Daml export: make paths relative to daml.yaml (#10388) 90c3582 treat exerciseResult structurally for isReplayedBy (#10381) 27a0c69 Stop swallowing error message in non-repudiation conformance tests (#10387) 22b6101 rotate release duty after 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10346) 5242e2c LF: drop old serializability check for Values (#10382) ee75530 LF: Specify nesting constraint for serialized values. (#10375) 4a33c03 LF: Add check of nesting in SValue.toValue (#10370) 91529ee clear up record specifications in http-json integration tests (#10366) e8247af update compat versions for 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10354) 74751ba Populate workflow-id in the test-tool scenarios (#10372) da9f8e3 clean-up perf tests (#10355) 42b70ad Fetch actingParties always non-empty for supported versions (>=1.6) (#10357) 37ff1a6 ledger-configuration: Return a structured error from checkTime. [KVL-1002] (#10373) 66284c1 Limit length of package ids to 64 characters (#10368) a56cfea even earlier mount failure detection (#10371) 1bc0ccd update NOTICES file (#10367) 9c9b91e Support deletion of a large number of contracts (#10353) 1b5f99e Stop printing stacktrace on logging setup failures (#10364) c0a24fe HA PoC behind a feature flag [DPP-426] (#10227) 63739fa Add conformance test for deeply nested values (#10319) faf479e LF: add context in LookupError (#10314) 68dcda0 Drop unused textType from JSON API Oracle queries (#10356) 49745f6 Re-add `application_id` to `DamlCommandDedupKey` [KVL-1000] (#10341) 27d439d LF: Compile netsed ELets using constant stack (#10337) 628aa22 kvutils: Refined transaction validation [KVL-1015] (#10066) d1e84c8 participant-integration-api: Fill out stubs in ApiSubmissionServiceSpec. (#10349) 905d8ad remove duplicated rule in create-daml-app dlint (#10352) bdc3e50 Separate ledger export related message from other kvutils messages [KVL-980] (#10343) 70e8ff4 participant-integration-api: De-spacify PostCommitValidationSpec. (#10350) 186d279 release 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10345) e58c7ba fix template dot-files (#10342) cf2b61e participant-state: Remove the aliases to `Ref.LedgerString`. (#10325) 8148137 [JSON-API] Include the logging context in the ledger client for consistent logging (#10332) c9666c7 Drop unnecessary mutability from speedy OnLedger state (#10340) 60dd96a update NOTICES file (#10347) ``` Changelog: ``` [Integration Kit] Moved definitions of `DamlSubmission` and `DamlSubmissionBatch` to a separate proto file under the package `com.daml.ledger.participant.state.kvutils.wire`. In case you are directly referencing these messages you will have to update your imports. - [JSON-API] Schema versioning was introduced to the db schema. Because of this the field `createSchema` in the jdbcConfig was deprecated. Via the field `start-mode` you can specify: 1. `create-only`: This is equal to the behaviour of `createSchema=true` so the db schema is created and then the application terminates. 2. `start-only`: With this the schema version is checked and if no version or an version was found which is not equal to the internal schema version then the application terminates. This is also the replacement of `createsSchema=false`. 3. `create-if-needed-and-start`: With this the schema version is checked and if no version or an version was found which is not equal to the internal schema version then the schema will be created/updated and the application proceeds with the startup. 4. `create-and-start`: Similar to the first option but instead of terminating the application proceeds with the startup. - [JSON-API] The json api now correctly shutdowns at startup if the provided db connection is invalid in case of `createSchema=false` simplify oracle migration scripts - [Daml Compiler] Imports of internal modules from stable packages are no longer illegal. Previously, the compiler raised an error when it encountered imports of internal modules such as `DA.Internal.Template`. Such imports are now accepted by the compiler. Note, however, that internal modules are still not part of the stable API. Fixes #10379 [Integration kit] Extended the Ledger API test tool with tests for the pruning of all divulgence events. - [Daml export] The generated paths to data-dependencies DALFs are now relative to the generated daml.yaml. Fixes #10378. - [JSON API] Fix an error where transactions that delete a large number of contracts resulted in stackoverflows with the PostgreSQL backend and database errors with Oracle. [Integration Kit] The command de-duplication key now also includes the daml application ID * [Integration Kit] Made `daml_kvutils.proto`'s location follow its proto package and moved `LedgerExportEntry` into a separate proto file. You may have to update your proto import statements in case you are directly importing proto files from the kvutils library. - [JSON-API] Connection tries from the json api to the ledger now include the logging context, more specifically the instance_uuid is included in each logging statement. ``` CHANGELOG_BEGIN CHANGELOG_END

@remyhaemmerle-da

This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @remyhaemmerle-da is in charge of this release. Commit log: ``` b5e9d86 Moved DamlSubmission* into separate proto file [KVL-980] (#10362) 0da814d Let stable packages bypass LF version restrictions. (#10377) c97cbca [JSON-API] Validate schema version & add minimal options for schema creation (#10374) ebb8fab Add a ContractDao benchmark for payload queries (#10426) 85af078 LF: parser for LF versions (#10424) b976c9c Disable autocommit for hikariCP for http-json-api db conn (#10427) 3ca46a4 Removed unused import. (#10425) 4d12493 Introduce buf checks [KVL-980] (#10411) 1c4ae50 Revert "Upgrade hikari to latest jdk8 version (#10406)" (#10421) fe1b642 Don't fail if logs directory exists already (#10423) 7c88b56 participant-integration-api: Fix completion debug log output. (#10415) fc305e6 [JSON-API] Shutdown on startup if the db connection is invalid (#10360) 6db5869 Update vcredist (#10417) 4b55f1a Connection pool for Contract Dao (#10359) 72cf2f3 LF: replace bazel keyword stable by default (#10410) 2bdcb7b update NOTICES file (#10414) 39c6e0b Fix oracle message too long error (#10413) 2094e24 Indexer ValidateAndWaitOnly startup mode for canton participant HA (#10290) ad13a86 Windows dev-env Powershell 7 compatibility (#10408) 3cedd83 Easy to parse ledger-api-bench-tool logs (#10320) 16ff20c Fix links in changelog (#10409) b325e8a participant-state: Remove `WriteService#rejectSubmission`. (#10407) 9be520c Keep the participant-state API prefixed. [KVL-1002] (#10405) d88dc71 Upgrade hikari to latest jdk8 version (#10406) 8b337bd Publish ledger-indexer-benchmark (#10401) 9e05f38 ledger-api-domain: Store the deduplication duration in `Commands`. [KVL-1002] (#10403) 9c064da Allow imports of internal modules (#10397) b9518ce participant-state-metrics: Add wrappers for v2. (#10404) c3a3d60 don't call Gary, he's on holiday (#10400) 221d0a0 use doobie 0.9.0 Fragment-in-Fragment interpolation in json-api db-backend (#10399) 17709b5 use a single SQL query for any number of json-api query pairs (#10344) 6a16684 Stop publishing the db-backend artifact (#10396) 1bed05f Treat KeyWithMaintainers field structurally in all node types. (#10392) d7077e1 Introduce locally-defined `Rejection` reasons instead of the participant-state rejection reason type. [KVL-1002] (#10376) 96f0483 [Divulgence pruning] Conformance tests implementation [DPP-484] (#10385) 28c5e9a update NOTICES file (#10386) 3879452 fix cut&paste typo bug; there are no insig lookup tweaks! (#10389) 7df9758 Daml export: make paths relative to daml.yaml (#10388) 90c3582 treat exerciseResult structurally for isReplayedBy (#10381) 27a0c69 Stop swallowing error message in non-repudiation conformance tests (#10387) 22b6101 rotate release duty after 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10346) 5242e2c LF: drop old serializability check for Values (#10382) ee75530 LF: Specify nesting constraint for serialized values. (#10375) 4a33c03 LF: Add check of nesting in SValue.toValue (#10370) 91529ee clear up record specifications in http-json integration tests (#10366) e8247af update compat versions for 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10354) 74751ba Populate workflow-id in the test-tool scenarios (#10372) da9f8e3 clean-up perf tests (#10355) 42b70ad Fetch actingParties always non-empty for supported versions (>=1.6) (#10357) 37ff1a6 ledger-configuration: Return a structured error from checkTime. [KVL-1002] (#10373) 66284c1 Limit length of package ids to 64 characters (#10368) a56cfea even earlier mount failure detection (#10371) 1bc0ccd update NOTICES file (#10367) 9c9b91e Support deletion of a large number of contracts (#10353) 1b5f99e Stop printing stacktrace on logging setup failures (#10364) c0a24fe HA PoC behind a feature flag [DPP-426] (#10227) 63739fa Add conformance test for deeply nested values (#10319) faf479e LF: add context in LookupError (#10314) 68dcda0 Drop unused textType from JSON API Oracle queries (#10356) 49745f6 Re-add `application_id` to `DamlCommandDedupKey` [KVL-1000] (#10341) 27d439d LF: Compile netsed ELets using constant stack (#10337) 628aa22 kvutils: Refined transaction validation [KVL-1015] (#10066) d1e84c8 participant-integration-api: Fill out stubs in ApiSubmissionServiceSpec. (#10349) 905d8ad remove duplicated rule in create-daml-app dlint (#10352) bdc3e50 Separate ledger export related message from other kvutils messages [KVL-980] (#10343) 70e8ff4 participant-integration-api: De-spacify PostCommitValidationSpec. (#10350) 186d279 release 1.16.0-snapshot.20210720.7404.0.b7cf42d1 (#10345) e58c7ba fix template dot-files (#10342) cf2b61e participant-state: Remove the aliases to `Ref.LedgerString`. (#10325) 8148137 [JSON-API] Include the logging context in the ledger client for consistent logging (#10332) c9666c7 Drop unnecessary mutability from speedy OnLedger state (#10340) 60dd96a update NOTICES file (#10347) ``` Changelog: ``` [Integration Kit] Moved definitions of `DamlSubmission` and `DamlSubmissionBatch` to a separate proto file under the package `com.daml.ledger.participant.state.kvutils.wire`. In case you are directly referencing these messages you will have to update your imports. - [JSON-API] Schema versioning was introduced to the db schema. Because of this the field `createSchema` in the jdbcConfig was deprecated. Via the field `start-mode` you can specify: 1. `create-only`: This is equal to the behaviour of `createSchema=true` so the db schema is created and then the application terminates. 2. `start-only`: With this the schema version is checked and if no version or an version was found which is not equal to the internal schema version then the application terminates. This is also the replacement of `createsSchema=false`. 3. `create-if-needed-and-start`: With this the schema version is checked and if no version or an version was found which is not equal to the internal schema version then the schema will be created/updated and the application proceeds with the startup. 4. `create-and-start`: Similar to the first option but instead of terminating the application proceeds with the startup. - [JSON-API] The json api now correctly shutdowns at startup if the provided db connection is invalid in case of `createSchema=false` simplify oracle migration scripts - [Daml Compiler] Imports of internal modules from stable packages are no longer illegal. Previously, the compiler raised an error when it encountered imports of internal modules such as `DA.Internal.Template`. Such imports are now accepted by the compiler. Note, however, that internal modules are still not part of the stable API. Fixes #10379 [Integration kit] Extended the Ledger API test tool with tests for the pruning of all divulgence events. - [Daml export] The generated paths to data-dependencies DALFs are now relative to the generated daml.yaml. Fixes #10378. - [JSON API] Fix an error where transactions that delete a large number of contracts resulted in stackoverflows with the PostgreSQL backend and database errors with Oracle. [Integration Kit] The command de-duplication key now also includes the daml application ID * [Integration Kit] Made `daml_kvutils.proto`'s location follow its proto package and moved `LedgerExportEntry` into a separate proto file. You may have to update your proto import statements in case you are directly importing proto files from the kvutils library. - [JSON-API] Connection tries from the json api to the ledger now include the logging context, more specifically the instance_uuid is included in each logging statement. ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines DAML Build <[email protected]>

nmarton-da force-pushed the dpp-426-participant-ha-support-poc-rolledback branch 5 times, most recently from a38a249 to 373d056 Compare July 10, 2021 20:12

rautenrieth-da changed the title ~~First draw of HA PoC~~ First draw of HA PoC [DPP-426] Jul 12, 2021

meiersi-da mentioned this pull request Jul 12, 2021

First draw of HA PoC #10174

Closed

6 tasks

meiersi-da reviewed Jul 12, 2021

View reviewed changes

nmarton-da commented Jul 12, 2021

View reviewed changes

libs-scala/oracle-testing/src/main/scala/testing/oracle/OracleAround.scala Show resolved Hide resolved

nmarton-da force-pushed the dpp-426-participant-ha-support-poc-rolledback branch from 373d056 to efc03cc Compare July 12, 2021 23:56

meiersi-da reviewed Jul 13, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala Outdated Show resolved Hide resolved

mziolekda reviewed Jul 13, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/store/backend/StorageBackend.scala Outdated Show resolved Hide resolved

mziolekda reviewed Jul 13, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/KillSwitchCaptor.scala Outdated Show resolved Hide resolved

mziolekda reviewed Jul 13, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PollingChecker.scala Show resolved Hide resolved

nmarton-da marked this pull request as ready for review July 13, 2021 19:57

nmarton-da requested review from fabiotudone-da, gerolf-da, miklos-da and rautenrieth-da as code owners July 13, 2021 19:57

nmarton-da requested a review from a user July 13, 2021 19:57

nmarton-da requested review from stefanobaghino-da and tudor-da as code owners July 13, 2021 19:57

nmarton-da force-pushed the dpp-426-participant-ha-support-poc-rolledback branch from 4175a74 to 5a7cd1a Compare July 13, 2021 20:18

mziolekda reviewed Jul 14, 2021

View reviewed changes

...t-integration-api/src/main/scala/platform/store/backend/common/InitHookDataSourceProxy.scala Outdated Show resolved Hide resolved

mziolekda reviewed Jul 14, 2021

View reviewed changes

...r/participant-integration-api/src/main/scala/platform/store/appendonlydao/DbDispatcher.scala Outdated Show resolved Hide resolved

nmarton-da force-pushed the dpp-426-participant-ha-support-poc-rolledback branch from 89d4e45 to e3097ee Compare July 14, 2021 21:00

mziolekda reviewed Jul 15, 2021

View reviewed changes

...cipant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala Show resolved Hide resolved

meiersi-da reviewed Jul 15, 2021

View reviewed changes

rautenrieth-da reviewed Jul 15, 2021

View reviewed changes

mziolekda reviewed Jul 15, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/HaCoordinator.scala Show resolved Hide resolved

tudor-da reviewed Jul 20, 2021

View reviewed changes

ledger/participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala Outdated Show resolved Hide resolved

mziolekda changed the title ~~First draw of HA PoC [DPP-426]~~ HA PoC behind a feature flag [DPP-426] Jul 20, 2021

tudor-da reviewed Jul 20, 2021

View reviewed changes

tudor-da approved these changes Jul 21, 2021

View reviewed changes

nmarton-da added 21 commits July 21, 2021 22:52

Switches to DataSource wrapping in HikariCP instantiation

3d684e7

changelog_begin changelog_end

Adds DBLockStorageBackend

f9a6db5

- this is the abstraction and the implementation of database level locking - with support for Oracle and Postgres changelog_begin changelog_end

Adds HaCoordinator and implementation

1130116

- this is the core implementation of the Participant HA feature changelog_begin changelog_end

Wiring of HaCoordinator in parallel indexer

b0259c8

changelog_begin changelog_end

Temporal log-level settings to see HA related logs

ae4dabc

changelog_begin changelog_end

Changes as per review

1b340c3

* Pulling out and fixing concurrency issue with KillSwitchCaptor * Fixing typos, doc * Renames * Fixes logging changelog_begin changelog_end

Some formatting changes after rebase

f96cf32

changelog_begin changelog_end

Preparation for merge

0e2969e

* Adds feature flag * Removes TODOs * Removes extra logging * Remove main-connection-lost simulation changelog_begin changelog_end

Removes some dead code

53b1b1b

changelog_begin changelog_end

Minor changes based on review

0916d47

changelog_begin changelog_end

More changes as per review

4573b91

* Increase log level for a potentially transient log message * Adds logging to the second getConnection method in InitHookDataSourceProxy * Rename changelog_begin changelog_end

Using stronger default lock identifiers

b7319ee

As suggested in the design document changelog_begin changelog_end

More changes as per review

0d2e4a3

* Wording changes * Unwrapping a single abstract method for clarity * Comment changes * Logging changes * Changes the name of the feature flag changelog_begin changelog_end

Removes the comment on warning on problematic compile dependency

8246151

As discussed in the PR, the note is not needed by now. changelog_begin changelog_end

Further changes as per review

7d0fe79

* removing jdbcUrl from HikariDataSourceOwner * comment changes * renames * re-adding an override * removing some parsing logic from PgSynchronousCommitValue changelog_begin changelog_end

Restructuring DataSourceConfig for more clarity on StorageBackend imp…

7d890a9

…lementation related configurations changelog_begin changelog_end

Rename feature flag command line argument

26d55b2

changelog_begin changelog_end

Minor changes based on review

a8382b2

changelog_begin changelog_end

nmarton-da force-pushed the dpp-426-participant-ha-support-poc-rolledback branch from 6b9da61 to a8382b2 Compare July 21, 2021 21:06

nmarton-da merged commit c0a24fe into main Jul 21, 2021

nmarton-da deleted the dpp-426-participant-ha-support-poc-rolledback branch July 21, 2021 22:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HA PoC behind a feature flag [DPP-426] #10227

HA PoC behind a feature flag [DPP-426] #10227

nmarton-da commented Jul 9, 2021

meiersi-da left a comment

meiersi-da left a comment

rautenrieth-da left a comment

tudor-da Jul 20, 2021 •

edited

Loading

nmarton-da Jul 21, 2021

tudor-da left a comment

HA PoC behind a feature flag [DPP-426] #10227

HA PoC behind a feature flag [DPP-426] #10227

Conversation

nmarton-da commented Jul 9, 2021

Pull Request Checklist

meiersi-da left a comment

Choose a reason for hiding this comment

meiersi-da left a comment

Choose a reason for hiding this comment

rautenrieth-da left a comment

Choose a reason for hiding this comment

tudor-da Jul 20, 2021 • edited Loading

Choose a reason for hiding this comment

nmarton-da Jul 21, 2021

Choose a reason for hiding this comment

tudor-da left a comment

Choose a reason for hiding this comment

tudor-da Jul 20, 2021 •

edited

Loading