Minor changes based on review

changelog_begin changelog_end
digital-asset · Jul 21, 2021 · a8382b2 · a8382b2
1 parent 26d55b2
commit a8382b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.../participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala b/.../participant-integration-api/src/main/scala/platform/indexer/ha/PreemptableSequence.scala
@@ -126,8 +126,9 @@ object PreemptableSequence {
         go(body).transformWith {
           // since we check countdown to 0, starting from negative means unlimited retries
           case Failure(ex) if maxAmountOfRetries == 0 =>
-            logger.info(
-              s"Maximum amount of retries reached ($maxAmountOfRetries) failing permanently. (${ex.getMessage})"
+            logger.warn(
+              s"Maximum amount of retries reached ($maxAmountOfRetries) failing permanently.",
+              ex,
             )
             Future.failed(ex)
           case Success(t) => Future.successful(t)

diff --git a/...ant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala b/...ant-integration-api/src/main/scala/platform/indexer/parallel/ParallelIndexerFactory.scala
@@ -127,7 +127,7 @@ object ParallelIndexerFactory {
                 .map(_ -> System.nanoTime())
             )
               .map(_ => ())
-              .keepAlive( // TODO ha: remove as stable. This keepAlive approach was introduced for safety with async commit. This is still needed until HA is mandatory for Postgres to ensure safety with async commit.
+              .keepAlive( // TODO ha: remove as stable. This keepAlive approach was introduced for safety with async commit. This is still needed until HA is mandatory for Postgres to ensure safety with async commit. This will not needed anymore if HA is enabled by default, since the Ha mutual exclusion implementation with advisory locks makes impossible to let a db-shutdown go undetected.
                 keepAliveMaxIdleDuration,
                 () =>
                   if (dbDispatcher.currentHealth() == HealthStatus.healthy) {