Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly version to 2018-06-20 #1765

Closed
wants to merge 1 commit into from

Conversation

Eijebong
Copy link
Member

No description provided.

@Eijebong
Copy link
Member Author

This is needed for #1742

@Eijebong Eijebong requested a review from a team June 25, 2018 00:13
@@ -53,7 +53,7 @@ fn usecs_to_duration(usecs_passed: u64) -> Duration {

fn duration_to_usecs(duration: Duration) -> u64 {
let seconds = duration.as_secs() * USEC_PER_SEC;
let subseconds = duration.subsec_nanos() / NANO_PER_USEC;
let subseconds = duration.subsec_micros();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated, but 👍 if it doesn't bump our stable version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy complained about it ;)

@Eijebong Eijebong changed the title Update nightly version to 2018-06-23 Update nightly version to 2018-06-20 Jun 25, 2018
@sgrif
Copy link
Member

sgrif commented Jul 10, 2018

@Eijebong Any blockers on this?

@Eijebong
Copy link
Member Author

Yeah I need to find time to get #1742 in there

@Eijebong
Copy link
Member Author

Superseded by #1789

@Eijebong Eijebong closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants