Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #1742

Closed
wants to merge 1 commit into from
Closed

update deps #1742

wants to merge 1 commit into from

Conversation

rizakrko
Copy link

Updates:
quote: 0.5 => 0.6
syn: 0.13 => 0.14
proc-macro2: 0.3 => 0.4

@sgrif
Copy link
Member

sgrif commented May 30, 2018

Is there a specific reason we need any of these changes?

@rizakrko
Copy link
Author

There is no particular reason, just a routine update

@sgrif
Copy link
Member

sgrif commented May 30, 2018

I'd prefer not to arbitrarily churn code unless there's a specific reason, especially WRT things as unstable as syn and proc_macro2. If someone on the core team is reading and strongly disagrees, feel free to reopen.

@sgrif sgrif closed this May 30, 2018
@sgrif
Copy link
Member

sgrif commented May 30, 2018

@Eijebong disagrees

@sgrif sgrif reopened this May 30, 2018
@Eijebong
Copy link
Member

I don't think they're that unstable and I'd prefer to review 0.13 -> 0.14 and then 0.14 -> whatever than jumping two versions.

@rizakrko
Copy link
Author

Failure is related to changes in nightly compiler, so #51042 has to be merged, and then clippy and related nightly needs to be updated.

@weiznich weiznich requested a review from a team May 31, 2018 08:29
@KamilaBorowska
Copy link

KamilaBorowska commented Jun 18, 2018

If somebody needs a reason, this reduces amount of compilation if using diesel with another crate which has newest version of those dependencies (a specific example - serde).

@Eijebong
Copy link
Member

Superseded by #1789

@Eijebong Eijebong closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants