-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier keys #585
Modifier keys #585
Conversation
…se still work when you specify the direction
castervoice/lib/ccr/core/nav.py
Outdated
"(control shift | que)": "cs", | ||
"control alt": "ca", | ||
"(shift alt | alt shift)": "sa", | ||
"(control alt shift | control shift alt)": "csa", # control must go first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow composition with fly, shin, alt as well. ie "fly alt shin" should be an option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "cass" as an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the shortened names for the rarer combination modifiers (like control alt shift). Those commands would be probably not often used so I don't know that it's a good idea to introduce a bunch of new commands like that with a short name that might cause misrecognitions at least if they are CCR. On the other hand, some users may want to use these commands in something like a text editor that has a lot of complex hotkeys so for them the short name would be worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't feel strongly about it either way. People can add them
right from when I started using caster I added What do people think about making this change here as well? Of course we can still keep Wally as an option but it gives some nice single syllable options for these powerful navigation commands. @LexiconCode, @mrob95 input on this please EDIT: I didn't actually realize that the functionality I usually use is already there in this PR. The spec for page up is "page up" instead of "sun" but I can now say "shin page up" and it works. |
castervoice/lib/ccr/core/nav.py
Outdated
"(shift | shin)": "s", | ||
"alt": "a", | ||
"(control shift | que)": "cs", | ||
"control alt": "ca", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
control alt | cult
castervoice/lib/ccr/core/nav.py
Outdated
"alt": "a", | ||
"(control shift | que)": "cs", | ||
"control alt": "ca", | ||
"(shift alt | alt shift)": "sa", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| salt
I think this PR is going to help a lot for those of us who switch between typing and voice control! |
@alexboche are you able to write out all the functional changes in this PR in your first comment? I was about to solicit comments on the Caster channel but realised that people would have to dig into the code to work out the changes. |
I have done so. Let me know if further elaboration is necessary. |
flitch etc as well |
This can be tested and merged once documentation and conflicts are resolved. |
I tried to do the documentation in the caster quick reference. Even without making any changes, when I try to compile the latex, I get the error message pointing to line 436. "! Missing $ inserted." On that line,the code is:
Any suggestions? |
A bit about my set up for latex. I found Miktex and Texmaker to be plug-and-play which none of the other editors or latex compilers seem to provide. In terms of troubleshooting does your error happen with the vanilla |
Not sure what changed,it's working now. As I add things, things get cut off at the end of the mini page. Is there a way to get everything to line up nicely instead of having to manually adjust the mini pages all the way through the document every time I add something? |
I'm still learning a bit myself with latex. Therefore I think the easiest solution would be to upload your working file I will take a look. |
Here is what I have. The issue seems that if I move one section to a different many page that messes up the next section and so on and I end up having to shift everything over by a page which is a huge pain, there must be a better way. |
Thanks. Regarding git you might have to do |
If you click on the latest commit, which is called, "first draft add to quick reference",you should be able to see the changes to the quick reference. Thanks |
optimized imports
@mrob95 I can't quite get figure out how to make the latex play nicely without running out of margins. Any tips? |
I just added a new command for making keystroke commands. The command is "keystroke [] ". So now saying "keystroke control shift delta" should type out I also fixed the typo with the home key. |
You are right! It should go there and not in |
Okay I moved the new command for creating keystroke commands into the voice dev command file and called it dev key. If you just say dev key, then it will move the cursor inside the key action,but if you specify the keys,the cursor will be left outside the key action. |
@alexboche I'm fine merging this without the documentation and we can remove the edits fromCasterQuickReference.tex and CasterQuickReference.tex. We can include the documentation in #629 as that issue matures. |
I undid the changes to the caster quick reference. |
I just added the ability to say |
That's brilliant! For some reason github won't let me resolve the conflicts online so you'll need to update it on your end. |
@LexiconCode if you want to resolve the conflicts you could try out my "git push back to pull request alex" function: Full workflow:
|
okay I merged with the latest caster and added the windows key commands which I forgot |
I added functionality for
<modifier_key> <button>
for all the modifier keys and nearly all possible buttons. the modifiers can be spoken as the regular English name or as the caster name (e.g. "control "or "fly"). To press a key without modifiers, say "hit ". The original caster master navigation command# "(<mtn_dir> | <mtn_mode> [<mtn_dir>]) [(<nnavi500> | <extreme>)]":
causes some ambiguity with these new commands so I commented it out. All the functionality is preserved except for the ability to say "fly", "shin", "que" without specifying "lease" or "ross" (if you specify the direction those still work fine). I added six new one syllable commands for that purpose (one for each in each direction) (bird, fird, brick, frick, blitch, flitch). I also added "latch", "ratch" which can be used instead of "ross/lease wally" in a stand-alone use or also in cases like "shin ross/lease wally" (you can still say ross/lease wally if you want).Currently the keys must all be prefaced by a modifier; this could be changed.
Right now I made them all these CCR (and allow some of them to be repeatable to varying degrees). Because the modifier commands have to be prefaced by the modifier I think the risk of misfires is lower than usual. It seems that grammar complexity is a limited resource that CCR commands use up. Given that some of these commands like "control alt insert" may never be used, I think we should not use that resource on them. Thus I think some of these should be made CCR before merging. I have not done so yet because I don't know yet which ones to make CCR and it is simpler to have it this way while I am still getting feedback from the maintainers and the community. In particular, I don't have a good understanding of the grammar complexity error.
To make it easier for people to give feedback on this, I'm including the full key dictionaries and new command names in this comment. The number after button_dictionary_ indicates the number of times the keys there which must be prefaced by modifiers can be repeated:
Note: the F keys are called "function ".
new command names (old names are preserved, see above):