Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and adjust keystroke commands in nav.py #480

Closed
wants to merge 3 commits into from

Conversation

alexboche
Copy link
Contributor

Pressing control backspace doesn't work in all application so I changed it to use control shift left/right delete. Also, as it was, "splat lease" was sometimes interpreted as to commands and sometimes interpreted as one. I remove this ambiguity by making "splat" for deleting words to the left and "sprat" for deleting words to the right.

Copy link
Collaborator

@kendonB kendonB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks like a lot of extra changes other than the one described in the PR. Isolating the changes to just those that the PR covers will help the maintainers with their review.

@LexiconCode LexiconCode added the WIP An work in progress label May 4, 2019
@alexboche alexboche changed the title Change 'splat' command for deleting words Add and adjust keystroke commands in nav.py May 4, 2019
@alexboche
Copy link
Contributor Author

I appreciate the feedback, and I'll try to do a better job with making pull requests into more atomic units with matching descriptions. I hope people can bear with me though. My understanding of git/github is poor and I am currently unwilling to use a mouse or keyboard at all for fear of exacerbating my hand problems, so it is possible that some users may be able to do things (especially relating to git and testing) much much faster than me. Sometimes I spend hours on something in git that somebody knowledgeable could probably do in thirty seconds. I certainly appreciate everyone's work here and realize that many users also have a lot of difficulty using a computer. I am working on my git skills so I can make more competent pull requests.

@kendonB
Copy link
Collaborator

kendonB commented May 4, 2019

I'm personally very excited that you're keen to make caster better! Feel free to ask questions (to google first, then gitter) if it feels like something is taking you a long time. If it feels like there's a faster way, there's probably a faster way. I'm also possibly going to get write access soon so that this process could go a bit faster.

@alexboche
Copy link
Contributor Author

Great thanks!

@kendonB
Copy link
Collaborator

kendonB commented May 4, 2019

I definitely like the idea of moving from "splat lease" and "splat ross" to two individual words (I do that in my own version using "nope" and "kay", the latter because I had a lot of trouble with other "cuter" alternatives). We would definitely want a bit more input on that decision, though. How would one revert to the old specs? Would words.txt be able to handle going back?

@LexiconCode
Copy link
Member

"words.txt" would not be able to handle multiple strings. However spec replacement is possible using

def replace_spec(rule, target, replacement):

Unfortunately the Filter Rules are not nearly as accessible as words.txt.

@kendonB
Copy link
Collaborator

kendonB commented May 5, 2019

@alexboche, can you elaborate a little bit on your experience with Dragon sometimes interpreting your command as "splat lease" and sometimes as "splat" then "lease"? Did it just seem random? If you leave a gap between the words in your speech it can get interpreted as two commands.

@kendonB
Copy link
Collaborator

kendonB commented May 5, 2019

I think a good general rule is to leave the core specs alone, unless they are buggy or obscure and no one uses them.

@kendonB kendonB added the Waiting for User Reply Waiting for OP reply label May 6, 2019
@kendonB kendonB removed the Waiting for User Reply Waiting for OP reply label May 21, 2019
@kendonB kendonB self-assigned this May 21, 2019
@kendonB kendonB added the Waiting for User Reply Waiting for OP reply label May 21, 2019
@kendonB
Copy link
Collaborator

kendonB commented Jun 22, 2019

this one is superseded by #585. closing

@kendonB kendonB closed this Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for User Reply Waiting for OP reply WIP An work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants