Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Bring me command #273

Merged
merged 5 commits into from
Oct 26, 2018
Merged

Conversation

comodoro
Copy link
Contributor

@comodoro comodoro commented Oct 10, 2018

Bring me feature ( "bring me <something>", with modifiable <something> )

@LexiconCode LexiconCode added WIP An work in progress Documentation Issues related to Documentation New Feature A new feature that is not currently implemented. Caster Issues pertaining to primarily the Caster project. labels Oct 10, 2018
@LexiconCode LexiconCode changed the title [WIP] Bring me Implemented Bring me command Oct 10, 2018
@LexiconCode
Copy link
Member

Very cool :)

@LexiconCode LexiconCode added this to the v6 milestone Oct 10, 2018
@comodoro
Copy link
Contributor Author

Default json file added to /bin/media (maybe there is a better location) And removed the add_selfmodrule line and unused Grammar import and it seems to work; it still depends on #271

It is being added in _caster.py as normal rule

By the way the wildcards in .gitignore, particularly *.json for the whole repository, made me figuring out for a while what is going on.

@LexiconCode
Copy link
Member

For consistency's sake I would leave in /bin/data/ instead of /bin/media. In the near future we will be moving the user configuration files outside the project folder to a user space.

@@ -0,0 +1,10 @@
{
"Best": "https://www.google.com/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible duplicate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god, I am so sorry! I will fix this shortly. I swear I will pay more attention from now on.

By the way, this is an indication of how bad my accuracy is. The word I actually said is "test".

@comodoro
Copy link
Contributor Author

Unfortunately opened windows do not get focus most of the time and there does not seem to be a good workaround

@LexiconCode
Copy link
Member

@comodoro
Copy link
Contributor Author

This is basically solved with the browser detection, I will finish it shortly, maybe after #269

@comodoro
Copy link
Contributor Author

I guess this could be considered as good as it can get now, with further changes like #302 etc being developed later.

@LexiconCode LexiconCode added Complete Pull request is complete and tested as defined by Contributor and removed WIP An work in progress labels Oct 26, 2018
@LexiconCode LexiconCode merged commit b83884d into dictation-toolbox:develop Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caster Issues pertaining to primarily the Caster project. Complete Pull request is complete and tested as defined by Contributor Documentation Issues related to Documentation New Feature A new feature that is not currently implemented.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants