-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Bring me command #273
Conversation
Very cool :) |
Default json file added to It is being added in _caster.py as normal rule By the way the wildcards in .gitignore, particularly *.json for the whole repository, made me figuring out for a while what is going on. |
For consistency's sake I would leave in |
@@ -0,0 +1,10 @@ | |||
{ | |||
"Best": "https://www.google.com/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A possible duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my god, I am so sorry! I will fix this shortly. I swear I will pay more attention from now on.
By the way, this is an indication of how bad my accuracy is. The word I actually said is "test".
Unfortunately opened windows do not get focus most of the time and there does not seem to be a good workaround |
May be related to https://github.com/synkarius/caster/issues/106? |
This is basically solved with the browser detection, I will finish it shortly, maybe after #269 |
I guess this could be considered as good as it can get now, with further changes like #302 etc being developed later. |
Bring me feature ( "bring me <something>", with modifiable <something> )