Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative approaches managing settings for 'alias'/'chain alias' and 'record from history' spec #302

Closed
LexiconCode opened this issue Oct 25, 2018 · 3 comments
Labels
Caster Core Spec Issues for Caster Specs that are not part of the application or language specific grammar/ccr Caster Issues pertaining to primarily the Caster project.

Comments

@LexiconCode
Copy link
Member

LexiconCode commented Oct 25, 2018

Issues

  1. Currently ccr.toml contains some duplicate settings found in settings.toml. In the case of alias = true and "chain alias" = true they both need to be enabled [feature_rules] and [selfmod] for the spec to work as expected. This is highly unexpected from the end-user perspective.

  2. The record from history spec represented in settings as history = true would fit under [feature_rules] instead of [selfmod]. I would expect to toggle these commands to the main settings file instead of ccr.

settings.toml

[feature_rules]
again = true
hmc = true
chainalias = true
alias = true

ccr.toml

[selfmod]
alias = true
"chain alias" = true
history = true

Solutions
So we can proceed with the following solutions.

  1. Merge settings [selfmod] from ccr.toml into [feature_rules] in settings.toml
  2. Eliminate ccr.toml and merge its settings into settings.toml
  3. Edit the defaults for [selfmod] to true in ccr.toml

References
The 'chain alias' command is nonfunctional #279
The 'record from history' command does not execute. #272

@LexiconCode LexiconCode added Caster Issues pertaining to primarily the Caster project. Community Feedback To discuss items of preference or utility not implementation. labels Oct 25, 2018
@comodoro
Copy link
Contributor

I agree with points one and three, I am not sure about ccr.toml. This way the settings file will become unnecessarily bulky. I think the point is that with exception of chain alias these are not really ccr commands. Also loading them could be at least moved to a separate module

@LexiconCode
Copy link
Member Author

Alright well I'm leaning towards option one.

@LexiconCode
Copy link
Member Author

After further evaluation ccrmerger.py option three was the simplest approach. Selfmod have to be explicitly enabled therefore should stay in the ccr.toml.

@LexiconCode LexiconCode added Caster Core Spec Issues for Caster Specs that are not part of the application or language specific grammar/ccr and removed Community Feedback To discuss items of preference or utility not implementation. labels Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caster Core Spec Issues for Caster Specs that are not part of the application or language specific grammar/ccr Caster Issues pertaining to primarily the Caster project.
Projects
None yet
Development

No branches or pull requests

2 participants