Reimplementation methods to find DNS path via the registry

[LexiconCode]

Do to issues #248 with Win32_Product and wmi I have re-implemented #242 #243 methods to find DNS path via the registry.

Overview of changes

• Does not rely on Win32_Product() from Wmi
• Wmi dependence removed for _winreg
• Renamed _validate_natspeak() to _validate_engine_path() as its engine agnostic
• Renamed exe_path to engine_path for clarity
• Renamed DisplayVersion to DnsVersion for clarity as needed
• Edited comments for clarity

[LexiconCode]

Remove the wmi package in command prompt or windows powershell.

pip uninstall wmi

[LexiconCode]

As it would be helpful to try out many set ups as possible to make sure everything functions as expected. The registry can be a finicky thing. The following attachment is a reimplementation of the _find_natspeak(). For testing purposes it only prints to counsel.

Three options

• Run _find_natspeak_test.py code in your favorite editor.
• Download a desired location. Right-click on the Windows 10 start menu. Click on 'command prompt' or 'windows powershell' then type "python absolute-path-to-_find_natspeak_test.py" and press enter.
• "shift right-click" In the folder containing _find_natspeak_test.py but not in or on the file/folder name and click on 'open command prompt' or 'windows powershell window here'

Example

python C:\Users\Main\Desktop_find_natspeak_test.py

The output should produce similar results

Searching Windows Registry For DNS...
Search Complete.

[mrob95]

I am still getting this error message:

[LexiconCode]

Thanks for testing! I'm able to reproduce the error local variable 'Publisher' referenced before assignment on a different machine.

[LexiconCode]

During QueryValue the value of a subkey for each installed program.

                DisplayName = _winreg.QueryValueEx(skey, 'DisplayName')[0]

DisplayName is undefined because of dirty registry keys or subkey does not have DisplayName string.
On my machine the first subkey parsed has all DisplayName, Publisher, DisplayVersion and InstallLocation. Therefore if software (subkey) further down on the list are missing an attribute it already contains a defined variable.

[LexiconCode]

The error should be fixed. It took me a while to out puzzle why it was happening in the context of the code on different machines.

_find_natspeak_test_v0.4.py.zip

[comodoro]

It seems to be working for me (DNS 13 Home, Windows 10 Pro):

d:\temp>python _find_natspeak_test.py
Searching Windows Registry For DNS...
Search Complete.

[LexiconCode]

@mrob95
Let me know if it works on your pc.

[mrob95]

Yes, working now