Detect alternate drive DNS install locations and versions #242 #243

LexiconCode · 2018-06-30T06:18:11Z

The premise is the search for DNS across all drives and to check DNS version.

…arches across all drives DNS root folder. dictation-toolbox#242

…velop

masisley · 2018-07-04T07:53:25Z

caster/lib/settings.py

+                    if os.path.isfile(ExePath):
+                        return ExePath
+                else:
+                    print ' Dragon Naturally Speaking' + str(Version) + ' is not supported by Castor. Only versions 13 and above are supported. Purchase Dragon Naturally Speaking 13 or above'


LexiconCode · 2018-07-04T14:05:03Z

@masisley Nice catch, thanks for reviewing! Because we use wmi and it takes time to search the registry of the def _find_natspeak():takes up to 15 seconds to complete. I don't want to add 15 seconds to the start up time of Caster.

I'll add a create something like def _verify_natspeak_path (): which will check if the current "ENGINE_PATH" is valid if not def _find_natspeak(): will be called to find the path.

… pip.bat dictation-toolbox#242 dictation-toolbox#243

LexiconCode · 2018-07-12T20:12:48Z

This should be feature complete and robust. Your feedback would be appreciated!

There are at least two ways you can help test.

Change "ENGINE_PATH": "C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe", in settings.json to an invalid path. Restart Dragon
Backup then delete settings.json regenerating default configuration. Restart Dragon

BazookaMusic · 2018-07-16T14:07:26Z

Will tested by tomorrow and report.

BazookaMusic · 2018-07-17T10:54:16Z

So:

This fails with an error:

Searching Windows Registry For DNS...
Search Complete.
Setting DNS path to C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe


ValueError('Extra data: line 85 column 2 - line 85 column 3 (char 3635 - 3636)',) while loading settings file: C:\NatLink\NatLink\MacroSystem\caster\bin\data\settings.json


(<type 'exceptions.ValueError'>, ValueError('Extra data: line 85 column 2 - line 85 column 3 (char 3635 - 3636)',), <traceback object at 0x0E9A3DC8>)

the engine path gets set to empty string. Restarting Dragon fixes this, the proper path is found and set,but the reboot command doesn't work until the path is set because it depends on it (extremely annoying).
2. Works as expected.

BazookaMusic

These changes should fix the engine path being replaced by empty string.

BazookaMusic · 2018-07-17T11:04:03Z

caster/lib/settings.py

@@ -71,7 +106,7 @@ def _find_natspeak():
        # EXECUTABLES
        "DEFAULT_BROWSER_PATH": "C:/Program Files (x86)/Mozilla Firefox/firefox.exe",
        "DOUGLAS_PATH": BASE_PATH + "/asynch/mouse/grids.py",
-        "ENGINE_PATH": _find_natspeak(),
+        "ENGINE_PATH": _validate_natspeak(),


Validate should return the exe path , instead it returns empty string as noted in the other comment.

BazookaMusic · 2018-07-17T11:06:00Z

caster/lib/settings.py

+                        print "Setting DNS path to " + exe_path
+                except Exception as e:
+                    print "Error saving json file " + str(e) + _SETTINGS_PATH
+                return ""


The functions should always return exe_path so that empty string is not set as the default engine path.

LexiconCode · 2018-07-17T14:56:24Z

I appreciate the feedback! Showing my ignorance here. What were the steps to reproduce this?

the engine path gets set to empty string. Restarting Dragon fixes this, the proper path is found and set,but the reboot command doesn't work until the path is set because it depends on it (extremely annoying).

My intent was the only condition when an empty string is set when _find_natspeak() cannot find DNS path/supported DNS or _validate_natspeak() has an error loading/saving settings.json.

An empty string "ENGINE_PATH":"" shouldn't cause failure to load settings.json. by breaking json formatting. I'll defer to your advice but I'm trying to understand my failure of logic.

In addition, could you upload settings.json that contains the extra data?

Edit:

One false assumption I made.

Load Caster with a valid ENGINE_PATH.

Edit settings.json ENGINE_PATH to an invalid path while castor is still loaded.

Execute the command "Reboot Dragon"

"Reboot Dragon" still executes as expected despite having an invalid ENGINE_PATH in settings.json. Therefore the valid path is being pulled from memory when castor initialized settings.json before editing with invalid path.

My assumption was that "settings.json" was read from file when the reboot command was executed. Which is partially correct in terms of what's displayed in command prompt but not the path set ENGINE_PATH in memory.

I can understand ENGINE_PATH has an empty string that the reboot Dragon command does not execute as expected. But that still doesn't explain your error.

In your I think in the scenario you described

An empty string was set settings.json after a previous error during the first time loaded
The functions correctly updated in settings.json.
Yet in memory ENGINE_PATH still had an empty string.

In that case reboot Dragon should fail that doesn't seem to be related to the error as you described.

From my understanding which is very limited and ENGINE_PATH:"" or ENGINE_PATH: invalid string/path should be equivalent in this context. Ex. ENGINE_PATH:"" is different than ENGINE_PATH: null A null value is invalid in .Json syntax. Which would lead to coercing to Unicode: need string or buffer, NoneType found

You can simulate this by changing settings.py deleting ENGINE_PATH:"some path" to ENGINE_PATH:"" Then restarting or starting DNS which doesn't replicate the error. Bottom line is I'm missing something possibly related to the order of execution of code?

…tion-toolbox#242

…'empty string'"

BazookaMusic · 2018-07-18T10:06:34Z

Destroy the path and reboot:
"ENGINE_PATH": "C:/Programhello Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe",
the new path is:
"ENGINE_PATH": "",

The full error message because I missed an important line:

Search Complete.
Setting DNS path to C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe


ValueError('Extra data: line 85 column 3 - line 86 column 2 (char 3636 - 3639)',) while loading settings file: C:\NatLink\NatLink\MacroSystem\caster\bin\data\settings.json


(<type 'exceptions.ValueError'>, ValueError('Extra data: line 85 column 3 - line 86 column 2 (char 3636 - 3639)',), <traceback object at 0x0EB74DA0>)
Default settings values added: 7

The reboot Dragon command opens a file Explorer window to the correct path but doesn't actually run NatSpeak.exe. This could be unrelated to your additions so it could be ignored if the latter problem is fixed.

After restarting Dragon again:

Search Complete.
Setting DNS path to C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe

to see what happens in the first case with the loading, I put the _save call from the _init function in a comment. Your function somehow adds extra curly braces to the json file. This is why it fails to load and instead loads the default values which had the engine path set as empty string. The settings file is generated again so everything works after that.

LexiconCode · 2018-07-18T12:51:37Z

Thanks for explaining.

So to reproduce

Destroy the path and reboot:
"ENGINE_PATH": "C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe",
the new path is:
"ENGINE_PATH": "",

I can't reproduce the error.

Can you reproduce it by?

Backing up then deleting settings.json
Letting the default settings.json generate with the correct path
Edit the path and reboot:

"ENGINE_PATH": "C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe",
the new path is:
"ENGINE_PATH": "",

Is the error reproduced? If it is reproduced then it's definitely something wrong with the code if not I need to have your original settings.json.

LexiconCode · 2018-07-18T13:28:09Z

As for

The reboot Dragon command opens a file Explorer window to the correct path but doesn't actually run NatSpeak.exe.

Castor initializes loading settings.json into memory <- containing invalid engine path
_validate_natspeak() finds an invalid engine path and write a complete settings.json with the updated engine path.
Unfortunately the engine path still is invalid in memory and is not updated. reboot Dragon command opens a file Explorer window to the correct path because it reads from file not from memory to display path but the call is pulled from memory which is still invalid.

Check out def reboot(wsr=False): in utilities.py line 122

BazookaMusic · 2018-07-18T15:18:13Z

I first deleted settings.json, rebooted and then destroyed the path and rebooted again.
File generated from your code(commented out default settings override):https://ufile.io/gxd8h
original settings(after default settings override):https://ufile.io/7trlo
Exact same error , but the proper engine path is set after your latest change. Notice the extra braces in the last 2 lines of the first file.

BazookaMusic · 2018-07-18T15:38:48Z

This could be something wonky but what seems to fix the problem is to use a "w" flag instead of "r+" when you open settings.json inside validate_NatSpeak. Instead of truncating the file and then writing it ,you are writing over existing characters.Since your new configuration is actually a smaller file than the one I create with extra noise in the path ,some extra brackets remain in the end. After testing with longer noise text, this seems to be the case as the extra characters end up in other positions.

LexiconCode · 2018-07-18T16:00:35Z

Thank you for taking the time to test.

Feels like I'm banging my head against a brick wall. Fortunately it makes sense why I can't reproduce it up till now. My bad assumption was I thought it was overwriting the file. I really do dislike working with json in part because I'm new to utilizing it and because you can't update in place data.

I'm still flummoxed by the idea I can't reproduce it using. The default settings should be the same file size in terms lines of code.

Backing up then deleting settings.json
Letting the default settings.json generate with the correct path
Edit the path and reboot:

"ENGINE_PATH": "C:/Program Files (x86)/Nuance/NaturallySpeaking15/Program/natspeak.exe",
the new path is:
"ENGINE_PATH": "",

Regardless I believe you hit the nail on the head though with the root of the problem. I'll include "w" flag instead of "r+" in def _validate_natspeak()

LexiconCode · 2018-07-18T16:06:30Z

Hopefully this is resolved and let me know. Thanks for your time to review and test!

BazookaMusic · 2018-07-19T15:33:18Z

Seems to work great now!

Detect alternate drive DNS install locations and versions dictation-…

9272dbd

…toolbox#242

LexiconCode added WIP An work in progress Enhancement Enhancement of an existing feature labels Jun 30, 2018

Added logic to select DNS multiple Nuance products installed

333f4fa

LexiconCode self-assigned this Jun 30, 2018

Enhancement find_NatSpeak function. Added DNS check version check. Se…

8e4489d

…arches across all drives DNS root folder. dictation-toolbox#242

LexiconCode added Complete Pull request is complete and tested as defined by Contributor Needs Review A pull request needs a code review. and removed WIP An work in progress labels Jul 1, 2018

LexiconCode added 2 commits July 2, 2018 12:24

Merge branch 'develop' of https://github.com/synkarius/caster into de…

750021d

…velop

Find DNS path via the registry. dictation-toolbox#242

c5cad88

masisley reviewed Jul 4, 2018

View reviewed changes

masisley approved these changes Jul 4, 2018

View reviewed changes

LexiconCode added WIP An work in progress and removed Complete Pull request is complete and tested as defined by Contributor labels Jul 4, 2018

Logic to validate DNS engine path settings and added dependency 'wmi'…

75ee12a

… pip.bat dictation-toolbox#242 dictation-toolbox#243

LexiconCode added Complete Pull request is complete and tested as defined by Contributor and removed WIP An work in progress labels Jul 12, 2018

Minor edits

1a5a6c4

BazookaMusic suggested changes Jul 17, 2018

View reviewed changes

LexiconCode added this to the v6 milestone Jul 17, 2018

LexiconCode added 2 commits July 17, 2018 11:01

Fix ValueError: return 'exe_path' instead of an 'empty string'. dicta…

d67109d

…tion-toolbox#242

Minor correction to "Fix ValueError: return 'exe_path' instead of an …

ae3975d

…'empty string'"

Fix issue with saving settings.json

e21a6a3

LexiconCode merged commit bc867b9 into dictation-toolbox:develop Jul 19, 2018

LexiconCode removed the Needs Review A pull request needs a code review. label Sep 8, 2018

LexiconCode mentioned this pull request Sep 8, 2018

Reimplementation methods to find DNS path via the registry #252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect alternate drive DNS install locations and versions #242 #243

Detect alternate drive DNS install locations and versions #242 #243

LexiconCode commented Jun 30, 2018 •

edited

Loading

masisley Jul 4, 2018

LexiconCode commented Jul 4, 2018 •

edited

Loading

LexiconCode commented Jul 12, 2018

BazookaMusic commented Jul 16, 2018

BazookaMusic commented Jul 17, 2018

BazookaMusic left a comment

BazookaMusic Jul 17, 2018 •

edited

Loading

BazookaMusic Jul 17, 2018 •

edited

Loading

LexiconCode commented Jul 17, 2018 •

edited

Loading

BazookaMusic commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018

BazookaMusic commented Jul 18, 2018

BazookaMusic commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018

BazookaMusic commented Jul 19, 2018 •

edited

Loading

Detect alternate drive DNS install locations and versions #242 #243

Detect alternate drive DNS install locations and versions #242 #243

Conversation

LexiconCode commented Jun 30, 2018 • edited Loading

masisley Jul 4, 2018

Choose a reason for hiding this comment

LexiconCode commented Jul 4, 2018 • edited Loading

LexiconCode commented Jul 12, 2018

BazookaMusic commented Jul 16, 2018

BazookaMusic commented Jul 17, 2018

BazookaMusic left a comment

Choose a reason for hiding this comment

BazookaMusic Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

BazookaMusic Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

LexiconCode commented Jul 17, 2018 • edited Loading

BazookaMusic commented Jul 18, 2018 • edited Loading

LexiconCode commented Jul 18, 2018 • edited Loading

LexiconCode commented Jul 18, 2018

BazookaMusic commented Jul 18, 2018

BazookaMusic commented Jul 18, 2018 • edited Loading

LexiconCode commented Jul 18, 2018 • edited Loading

LexiconCode commented Jul 18, 2018

BazookaMusic commented Jul 19, 2018 • edited Loading

LexiconCode commented Jun 30, 2018 •

edited

Loading

LexiconCode commented Jul 4, 2018 •

edited

Loading

BazookaMusic Jul 17, 2018 •

edited

Loading

BazookaMusic Jul 17, 2018 •

edited

Loading

LexiconCode commented Jul 17, 2018 •

edited

Loading

BazookaMusic commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018 •

edited

Loading

BazookaMusic commented Jul 18, 2018 •

edited

Loading

LexiconCode commented Jul 18, 2018 •

edited

Loading

BazookaMusic commented Jul 19, 2018 •

edited

Loading