1.6.0-development #6454
Merged
1.6.0-development #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds handy helpers for performing algorithms on the entire container. They're prefixed with `c_` for container. This naming convention is identical to some popular C++ libraries, such as Abseil.
Follow-up to #6403
Also updates SDL2 version to the latest SDL2 branch commit.
This is the version that is currently installed on GitHub Actions.
Adds a `ParseInt` function which uses `std::from_chars`. From `std::from_chars` documentation: > Unlike other parsing functions in C++ and C libraries, > std::from_chars is locale-independent, non-allocating, and non-throwing. Co-authored-by: Andrew James <[email protected]>
No real need to persist this value
Also added an iterator based API, though it's not useful for this use-case. Might be nice in the future? The field/record iterators is single-pass input iterators with shared state. To avoid rescanning fields unnecessarily parseInt currently can only be called once, it would be possible to make these iterators bidirectional with a bit of extra state (holding onto the start pointer) Co-authored-by: Gleb Mazovetskiy <[email protected]>
Co-authored-by: staphen <[email protected]>
Usually we call fread in a loop until reaching EOF. Reaching EOF is not an error, so we should not log it as such. The error message was previously seen when loading demo files.
`DemoMsg` struct and event data are now kept separately. RAM usage for the timedemo messages: -85% (1.8 MiB -> 261 KiB) Demo (`.dmo`) file size: -57% (590,790 bytes -> 253,410 bytes)
|
Some conflicts already. For the timedemo, I guess we'll want to regenerate the file from |
|
@glebm would you be willing to resolve the conflict with master by converting it's demo to the new format? :( |
|
@AJenbo sure, shall I merge |
|
Yeah I think that makes sens as a way to resolve conflicts. I intent to merge develop with master rater then rebase once 1.5.1 is out. |
Reduces struct size and makes the types of coordinates more obvious.
Already checked at the start of the function, none of the sprite data lookups change that global.
glibc compatibility remains the same. We now use Clang 18 and static libc++ for the Aarch64 build. Linux x86 and x86_64 builds now use GCC 13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.