Adjust tests to work with data driven levels #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glebm looks like Android is having a linker error after the update to libmpq, do you know the solution on top of you head? |
|
Looks like Tests now build, but they are also failing... |
AJenbo
commented
Aug 25, 2023
There was a problem hiding this comment.
@StephenCWills we found a bug in GitHub :D
I replied to your comment while you where deleting it... making an empty review was the only way for me to get the comment tools back in to a normal state as it though I had an ongoing review but would not let me cancel it as there where 0 comments xD
StephenCWills
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently builds on the development branch fails, this should fix it
Removing UnPackNetPlayer_invalid_pLevel should be ok as ValidatePlayer() makes the case pretty hard to hit, and _pLevel being private makes it hard to setup the test.