fix: peer dependency issue with npm publish #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1628--dhis2-ui.netlify.app |
kabaros
force-pushed
the
fix/publish-fail
branch
from
d2c5cc7 to
f90fce3
Compare
dhis2-bot
added a commit
that referenced
this pull request
Nov 5, 2024
# [9.13.0](v9.12.0...v9.13.0) (2024-11-05) ### Bug Fixes * peer dependency issue with npm publish ([#1628](#1628)) ([1319654](1319654)) * **translations:** sync translations from transifex (master) ([7f22330](7f22330)) ### Features * update react peer dependency to react@18 ([#1624](#1624)) ([5d3c2a4](5d3c2a4))
dhis2-bot
added a commit
that referenced
this pull request
Nov 21, 2024
# [10.0.0-alpha.8](v10.0.0-alpha.7...v10.0.0-alpha.8) (2024-11-21) ### Bug Fixes * peer dependency issue with npm publish ([#1628](#1628)) ([1319654](1319654)) * update calendar tests for react 18 ([98831a7](98831a7)) * update testing-library for selector-bar ([893024d](893024d)) * **translations:** sync translations from transifex (master) ([d89ce94](d89ce94)) * **translations:** sync translations from transifex (master) ([7f22330](7f22330)) ### Features * add data sharing to sharing dialog [LIBS-677] ([#1629](#1629)) ([7e15c7f](7e15c7f)) * make input field clearable and add prefix icon ([#1619](#1619)) ([7f87fb4](7f87fb4)) * update react peer dependency to react@18 ([#1624](#1624)) ([5d3c2a4](5d3c2a4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm publishseems to be failing on CI on master - The error is pointing to conflicting versions of@types/react- this PR attempts to fix it (without adding a module resolution ). It seems like the incorrect version of @types/react (v17) is coming from selector-bar, which was using an outdated testing-library version. This change removes that dependency since components don't need their own test-library versions - a side effect of that was also that@testing-library/jestwas being hoisted to the top-level and was working there, even though it's not installed.The old docusaurus version we use, also points to an outdated @types/react version but I think adding a dev dependency at the top level should sort it.
PS: I don't know why this issue only appears on
npm publish.