feat: make input field clearable and add prefix icon #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1619--dhis2-ui.netlify.app |
Birkbjo
reviewed
Oct 15, 2024
Birkbjo
reviewed
Oct 15, 2024
components/input/src/input/input.js
Outdated
| } | ||
|
|
||
| .input-clearable input { | ||
| padding-right: 30px; |
There was a problem hiding this comment.
Suggested change
| padding-right: 30px; | |
| padding-inline-end: 30px; |
Birkbjo
reviewed
Oct 15, 2024
Birkbjo
reviewed
Oct 15, 2024
amcgee
reviewed
Oct 16, 2024
| @@ -90,6 +97,10 @@ const InputFieldProps = { | |||
| /** The [native `autocomplete` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-autocomplete) */ | |||
| autoComplete: PropTypes.string, | |||
| className: PropTypes.string, | |||
| /** function to clear the input value */ | |||
| clearText: PropTypes.func, | |||
There was a problem hiding this comment.
@d-rita do we need a separate callback function for this? I think it might be possible to just call setValue('')? Maybe there are cases when you want to reset it to the default value... but that could be handled by the setValue callback?
There was a problem hiding this comment.
In the Input component, I could use the onChange handler that we pass in to update value to an empty string. Then within the parent component where this InputField is being used, the onChange handler (which uses the setValue) can update the value accordingly. If there is a defaultValue, that can also be set within there.
amcgee
approved these changes
Oct 29, 2024
kabaros
approved these changes
Nov 18, 2024
dhis2-bot
added a commit
that referenced
this pull request
Nov 18, 2024
# [9.15.0](v9.14.1...v9.15.0) (2024-11-18) ### Features * make input field clearable and add prefix icon ([#1619](#1619)) ([7f87fb4](7f87fb4))
dhis2-bot
added a commit
that referenced
this pull request
Nov 21, 2024
# [10.0.0-alpha.8](v10.0.0-alpha.7...v10.0.0-alpha.8) (2024-11-21) ### Bug Fixes * peer dependency issue with npm publish ([#1628](#1628)) ([1319654](1319654)) * update calendar tests for react 18 ([98831a7](98831a7)) * update testing-library for selector-bar ([893024d](893024d)) * **translations:** sync translations from transifex (master) ([d89ce94](d89ce94)) * **translations:** sync translations from transifex (master) ([7f22330](7f22330)) ### Features * add data sharing to sharing dialog [LIBS-677] ([#1629](#1629)) ([7e15c7f](7e15c7f)) * make input field clearable and add prefix icon ([#1619](#1619)) ([7f87fb4](7f87fb4)) * update react peer dependency to react@18 ([#1624](#1624)) ([5d3c2a4](5d3c2a4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-699